Contrib.social

Add validation constraints to system.cron

Open on Drupal.org →
Created on 28 March 2024, about 1 year ago
Updated 16 April 2024, about 1 year ago

Problem/Motivation

system.cron has 3 property path that are not yet validatable:

./vendor/bin/drush config:inspect --filter-keys=system.cron --detail --list-constraints
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 --------------------------------------------- --------- ------------- ------ ------------------------------------------ 
  Key                                           Status    Validatable   Data   Validation constraints                    
 --------------------------------------------- --------- ------------- ------ ------------------------------------------ 
  system.cron                                   Correct   56%           ✅❓   ValidKeys: '<infer>'                      
   system.cron:                                 Correct   Validatable   ✅✅   ValidKeys: '<infer>'                      
   system.cron:_core                            Correct   Validatable   ✅✅   ValidKeys:                                
                                                                                 - default_config_hash                   
   system.cron:_core.default_config_hash        Correct   Validatable   ✅✅   NotNull: {  }                             
                                                                               Regex: '/^[a-zA-Z0-9\-_]+$/'              
                                                                               Length: 43                                
                                                                               ↣ PrimitiveType: {  }                     
   system.cron:logging                          Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here  
   system.cron:threshold                        Correct   Validatable   ✅✅   ValidKeys: '<infer>'                      
   system.cron:threshold.requirements_error     Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here  
   system.cron:threshold.requirements_warning   Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here  
 --------------------------------------------- --------- ------------- ------ ------------------------------------------

Steps to reproduce

  1. Get a local git clone of Drupal core 11.x.
  2. composer require drupal/config_inspector — or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 → or newer (which supports Drupal 11!)
  3. composer require drush/drush
  4. vendor/bin/drush config:inspect --filter-keys=system.cron --detail --list-constraints

Proposed resolution

Add validation constraints to:

  1. system.cron:logging
  2. system.cron:threshold.requirements_error
  3. system.cron:threshold.requirements_warning

For examples, search *.schema.yml files for the string constraints: 😊

Reach out to @borisson_ or @wimleers in the #distributions-and-recipes.

Remaining tasks

User interface changes

None.

API changes

Data model changes

More validation 🚀

Release notes snippet

None.

📌 Task
Status

Fixed

Version

11.0 🔥

Component
System  →

Last updated about 9 hours ago

No maintainer
Created by

🇮🇳India narendraR Jaipur, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024