Contrib.social

Fix warnings reported by PHPStan job

Open on Drupal.org →
Created on 25 March 2024, 3 months ago
Updated 14 June 2024, 13 days ago

Problem/Motivation

Fix warnings reported by PHPStan job
PHPStan errors - https://git.drupalcode.org/issue/jsonapi_extras-3435832/-/jobs/1714573

📌 Task
Status

Needs review

Version

3.0

Component

Code

Created by

🇮🇳India gaurav_manerkar Vasco Da Gama, Goa

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @gaurav_manerkar
  • Pipeline finished with Success
    2 months ago
    Total: 215s
    #153426
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 129s
    #174505
  • Pipeline finished with Failed
    about 1 month ago
    Total: 209s
    #174511
  • Pipeline finished with Failed
    about 1 month ago
    #174520
  • Pipeline finished with Success
    about 1 month ago
    Total: 274s
    #174528
  • Pipeline finished with Success
    about 1 month ago
    Total: 183s
    #174876
  • Pipeline finished with Success
    about 1 month ago
    Total: 185s
    #174962
  • Pipeline finished with Success
    about 1 month ago
    #174998
  • Pipeline finished with Success
    about 1 month ago
    Total: 430s
    #183821
  • First commit to issue fork.
  • Assigned to ankitv18
  • Comment 30 days ago →
    🇮🇳India ankitv18
  • Comment 30 days ago →
    🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
  • Comment 30 days ago →
    🇮🇳India ankitv18
  • Merge request !49Issue#3435834: Fixing phpstan issues. → (Open) created by ankitv18
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 30 days ago
    20 pass
  • Pipeline finished with Success
    30 days ago
    Total: 197s
    #184990
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 30 days ago
    20 pass
  • Pipeline finished with Success
    30 days ago
    Total: 201s
    #185062
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 30 days ago
    20 pass
  • Pipeline finished with Success
    30 days ago
    Total: 198s
    #185076
  • Pipeline finished with Success
    30 days ago
    Total: 302s
    #185083
  • Pipeline finished with Success
    29 days ago
    Total: 286s
    #185546
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 29 days ago
    20 pass
  • Pipeline finished with Success
    29 days ago
    Total: 272s
    #185598
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 29 days ago
    20 pass
  • Pipeline finished with Success
    29 days ago
    Total: 209s
    #185600
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 28 days ago
    20 pass
  • Pipeline finished with Success
    28 days ago
    Total: 207s
    #186949
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 28 days ago
    20 pass
  • Pipeline finished with Success
    28 days ago
    Total: 294s
    #186974
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 28 days ago
    20 pass
  • Pipeline finished with Success
    28 days ago
    Total: 217s
    #186991
  • Pipeline finished with Failed
    28 days ago
    Total: 234s
    #187080
  • Pipeline finished with Failed
    28 days ago
    Total: 249s
    #187089
  • Pipeline finished with Failed
    28 days ago
    Total: 169s
    #187097
  • Pipeline finished with Success
    28 days ago
    Total: 193s
    #187105
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 28 days ago
    20 pass
  • Pipeline finished with Success
    28 days ago
    Total: 248s
    #187120
  • Issue was unassigned.
  • Status changed to Needs review 28 days ago
  • Comment 28 days ago →
    🇮🇳India ankitv18

    All phpstan and phpcs issues are fixed which are reported in their pipelines.
    @bbrala can you please review MR!49 and merge if possible.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 28 days ago
    20 pass
  • Pipeline finished with Success
    28 days ago
    Total: 200s
    #187128
  • Pipeline finished with Failed
    27 days ago
    #188025
  • Pipeline finished with Failed
    27 days ago
    Total: 332s
    #188034
  • Pipeline finished with Success
    26 days ago
    Total: 170s
    #188633
  • Pipeline finished with Success
    26 days ago
    Total: 180s
    #188634
  • Pipeline finished with Success
    26 days ago
    Total: 172s
    #188832
  • Status changed to Needs work 25 days ago
  • Comment 25 days ago →
    🇯🇵Japan ptmkenny

    I did a basic review of the code. Marking "Needs work" based on the addition of a dependency that I don't think is actually required.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 23 days ago
    20 pass
  • Pipeline finished with Success
    23 days ago
    Total: 197s
    #191841
  • Status changed to Needs review 23 days ago
  • Comment 23 days ago →
    🇮🇳India ankitv18

    Made the changes as per feedback ~~ Pipeline are running perfectly fine
    @bbrala please review at your end.

  • Comment 22 days ago →
    🇯🇵Japan ptmkenny

    Did another review. Leaving it at "Needs review" as @bbrala is the maintainer and should also review this.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 22 days ago
    20 pass
  • Pipeline finished with Canceled
    22 days ago
    Total: 64s
    #191895
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 22 days ago
    20 pass
  • Pipeline finished with Success
    22 days ago
    Total: 198s
    #191897
  • Pipeline finished with Failed
    17 days ago
    Total: 232s
    #196339
  • Pipeline finished with Canceled
    17 days ago
    Total: 3s
    #196426
  • Pipeline finished with Canceled
    17 days ago
    Total: 81s
    #196427
  • Pipeline finished with Failed
    17 days ago
    Total: 282s
    #196430
  • Pipeline finished with Failed
    17 days ago
    #196438
  • Pipeline finished with Failed
    16 days ago
    Total: 229s
    #196472
  • Pipeline finished with Canceled
    16 days ago
    Total: 93s
    #196488
  • Pipeline finished with Failed
    16 days ago
    Total: 260s
    #196489
  • Pipeline finished with Success
    16 days ago
    #196863
  • Pipeline finished with Success
    16 days ago
    Total: 255s
    #196940
  • Pipeline finished with Success
    15 days ago
    Total: 56481s
    #197424
  • Pipeline finished with Canceled
    15 days ago
    Total: 24s
    #197955
  • Pipeline finished with Failed
    15 days ago
    Total: 242s
    #197956
  • Pipeline finished with Failed
    15 days ago
    #197959
  • Pipeline finished with Failed
    15 days ago
    Total: 262s
    #197974
  • Pipeline finished with Success
    15 days ago
    Total: 2056s
    #197979
  • Comment 13 days ago →
    🇮🇳India ankitv18
  • Pipeline finished with Failed
    7 days ago
    Total: 324s
    #204077
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024