Contrib.social

Automated Drupal 11 compatibility fixes for url_friendly_options

Open on Drupal.org →
Created on 25 March 2024, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment about 1 year ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-127659

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.9
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !2Automated Project Update Bot fixes → (Merged) created by project update bot
  • Status changed to Active 9 months ago
  • Comment 9 months ago →
    🇨🇦Canada deviantintegral

    Drupal now has a machine name field for options items. However, it kind of makes the experience worse, because it means that generated option keys will always use underscores which can have readability issues in URLs. We likely want to change how this module works so it alters the machine name field to always use dashes.

  • Assigned to mmenavas
  • Comment 23 days ago →
    🇺🇸United States mmenavas

    Thanks for the feedback @deviantintegral. I think this module is not working anymore as of Drupal 10.3 because hook_form_field_storage_config_edit_form_alter was deprecated → in 10.2. I am assigning this issue to myself so I can fix it for Drupal 10.3+ and 11+. I think the code changes will call for a major version bump on the next release.

  • Comment 13 days ago →
    System Message
  • Comment 13 days ago →
    System Message
  • Comment 13 days ago →
    🇺🇸United States mmenavas

    Since the 1.0.x branch was not compatible with 10.3+, I created a new branch (2.0.x) to include Drupal 10.3+ and 11 compatibility. Below is the summary of changes for the 2.0.0 release:

    Bugfixes:
    - Alter field_config_edit_form instead of field_storage_config_edit_form as the latter was deprecated in Drupal 10.2. (see https://www.drupal.org/node/3386675 → ).
    - Override machine name form element default behavior by using hyphens instead of underscores as the replacement for non alphanumeric characters.
    - Updated preg_match call to ensure second parameter is always a string.

    New Features:
    - Add functional (javascript) test.
    - Add gitlab CI integration.
    - Add Tugboat preview.

  • Comment 11 days ago →
    🇪🇸Spain marcoscano Barcelona, Spain

    Thanks for working on this! I left a review, nothing super blocking, but it would be good to check if we can improve the test without the waiting calls.
    Also, not sure if I'm seeing things right, but maybe the MR is being targeted against 1.x (instead of the 2.x new branch)
    Thanks!

  • Comment 9 days ago →
    🇺🇸United States mmenavas

    Thanks for the thorough review @marcoscano! I pushed code changes yesterday to address your feedback. Please let me know if I missed anything.

  • Pipeline finished with Skipped
    9 days ago
    #508297
  • Pipeline finished with Skipped
    9 days ago
    #508298
  • Pipeline finished with Skipped
    9 days ago
    #508299
  • Comment 9 days ago →
    System Message
  • Comment 9 days ago →
    🇪🇸Spain marcoscano Barcelona, Spain

    Thanks @mmenavas! Looks great 👍
    I went ahead and created https://www.drupal.org/project/url_friendly_options/releases/2.0.0 → after merging.

  • Comment 9 days ago →
    🇺🇸United States mmenavas

    Excellent! Thank you very much for making the release.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024