Automated Drupal 11 compatibility fixes for monitoring

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.2

acbramley → changed the visibility of the branch project-update-bot-only to hidden.

Blocked on https://www.drupal.org/project/past → D11 compat I believe.

try lenient + sed for the .info.yml change, like in entity_browser: https://git.drupalcode.org/project/entity_browser/-/blob/8.x-2.x/.gitlab...

There are few of the changes required within MR!18

1. Like sub-modules info.yml missing D11 support
2. Tests of sub-modules having public as scope property for module list.
3. 131 Call to deprecated function format_size():
   in drupal:10.2.0 and is removed from drupal:11.0.0. Use
   \Drupal\Core\StringTranslation\ByteSizeMarkup::create($size,
   $langcode)

Plus the usual default views key that needs to be removed that causes most test fails right now.

@berdir Need one confirmation before fixing below issue:

 Call to deprecated function format_size():                      
         in drupal:10.2.0 and is removed from drupal:11.0.0. Use         
           \Drupal\Core\StringTranslation\ByteSizeMarkup::create($size,  
         $langcode)                                                      
           instead.

As previous major pipeline is failing due to most of the required modules are already dropped the support of D9.

Can we also drop the support of D9 and provide minimum support of D10.2 so that we can avoid using of deprecationHelper or version_compare?

Yes, 10.2 is fine.

Moving into review now

There's a php deprecation about an undefined property, that's a PHP 8.3 thing that needs to be fixed too. Plus the comment on commerce info files. not sure what the disk error is about, will need to be investigated.

For below issue I need to debug on my local might be these properties is eliminated from drupal core

 /builds/issue/monitoring-3433496/src/Plugin/monitoring/SensorPlugin/DatabaseDiskUsagePlugin.php:159
    Undefined property: stdClass::$table_name

cc: @berdir @acbramley

@berdir It is catching up the submodules but I guess those modules which is specifically mentioned in the static $modules = []; and any of those modules in case missing from info.yml or composer.json require/require-dev section aren't covered with before_script.

No, it's not catching subfolders. Not without the globstar stuff being enabled: https://www.linuxjournal.com/content/globstar-new-bash-globbing-option. We need to use find.

Neither $modules definitions nor require-dev has anything to do with this. require-dev would fail on the composer step, $modules would complain about missing modules. It specifically complains about non-compatible, which is what the sed is trying to fix but doesn't find all files to replace.

Unsure why the undefined property error happens, looks like the query somehow doesn't return what we expect. could be a weird side effect of running this on the system database on CI, so you likely can't reproduce that locally.

Merging with the following additional changes:

* allowing commerce 3.x, no more patching required then for that
* remove simplenews dev dependency, we have no simplenews tests, not sure why that was still there
* fixed all tests, some were real issues, like the ajax changes and the config value sensor issues,

Automatically closed - issue fixed for 2 weeks with no activity.