- Issue created by @dydave
- Merge request !29Issue #3433198 by DYdave: Automated testing on GitLab CI: Added initial... β (Merged) created by dydave
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Liam Morland β made their first commit to this issueβs fork.
- Status changed to Needs review
9 months ago 9:06am 26 August 2024 - π«π·France dydave
Hi Joseph (@joseph.olstad),
Could you please help us take a look at this MR when you have some time ?
I've paid particular attention not to modify anything that could break Backward Compatibility (BC), such as translated strings or class names.
At this point, MR!29 seems to be passing all jobs except ESLint and PHPStan which are probably more complicated and would most likely require specific issues to fix :
MR!29 Pipeline: https://git.drupalcode.org/issue/shs-3433198/-/pipelines/264680Moving issue to Needs review and bumping to Major as an attempt to attract maintainers attention.
Feel free to let us know if you have any questions or concerns on any of the changes in the merge request or this ticket in general, we would surely be glad to help.
Thanks in advance! - π¨π¦Canada Liam Morland Ontario, CA π¨π¦
phpcs issues fixed.
phpunit tests were failing due to π Update templates so 11.0 is the default/current branch RTBC . I fixed this by pinning the version of the testing template as recommended in π Stop changing the meaning of tests Active .
- Status changed to RTBC
6 months ago 6:50pm 6 November 2024 - π§π¬Bulgaria pfrenssen Sofia
Looking great, also nice to see the coding standards check pass!
-
joseph.olstad β
committed 2c561733 on 2.0.x authored by
dydave β
Issue #3433198 by DYdave: Automated testing on GitLab CI: Added initial...
-
joseph.olstad β
committed 2c561733 on 2.0.x authored by
dydave β
-
joseph.olstad β
committed 7d83ae8d on 3.0.x authored by
dydave β
Cherry pick 2c561733d7c08d2 - 'Issue #3433198 by DYdave: Automated...
-
joseph.olstad β
committed 7d83ae8d on 3.0.x authored by
dydave β
- π¨π¦Canada joseph.olstad
did a partial cherry pick of the work from 2.0.x into 3.0.x . Not sure if this will work as expected.
- Status changed to Fixed
3 days ago 7:19pm 6 May 2025 - π¨π¦Canada joseph.olstad
Good enough for now, if you want to push this further , open a new issue