- Issue created by @BenStallings
- Status changed to Needs review
8 months ago 9:05pm 22 March 2024 - Status changed to Needs work
8 months ago 10:41pm 22 March 2024 - π¦πΊAustralia darvanen Sydney, Australia
Adding the template by itself doesn't run any PHPUnit tests, those need setting up. Also please set the variables to disable all of the failing linting tests and create follow-up issues to do the work to make them pass so they can be re-enabled.
- π¦πΊAustralia darvanen Sydney, Australia
@BenStallings I take it back, the template ran the PHPUnit tests in another module I imported the template for, any idea why it didn't here?
- π¦πΊAustralia darvanen Sydney, Australia
Oh..... this module doesn't have any PHPUnit tests. Right. You would think I knew that.
I've set the test support to be forward-looking rather than supporting old versions. Thank you for making it match the info file in the first instance (I've just changed that too in another issue).
-
darvanen β
committed 48723628 on 2.x authored by
BenStallings β
Issue #3433112 by darvanen, BenStallings: Add Gitlab CI
-
darvanen β
committed 48723628 on 2.x authored by
BenStallings β
- π¦πΊAustralia darvanen Sydney, Australia
Follow-ups:
π Create test Active
π CSPell - enable and fix Active
π ESLint - enable and fix Active
π PHPCS - enable and fix Fixed
π PHPStan - enable and fix Active - Status changed to Fixed
8 months ago 2:09am 23 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.