Create test

Ok, got this to a point where it's downloading the dependencies and running the test, the test is green at the moment but that's because it's just doing self::assertTrue(TRUE);.

I'm considering removing OPT_IN_NEXT_MAJOR since the token module is causing that to crash at the moment.

I'm considering removing OPT_IN_NEXT_MAJOR since the token module is causing that to crash at the moment.

You could add the following to the composer (next major) job so that it allows token to be installed. I recently started doing that myself.

composer (next major):
  variables:
    LENIENT_ALLOW_LIST: token

@mradcliffe you sir, are a gentleman and a scholar. Not only did I learn about a the lenient variable but also how to alter an existing job. Thank you.

I couldn't find much in the way of documentation on that variable, if you want to add more than one module is it a yaml array, comma separated, space separated?...

Ah, found it.

https://git.drupalcode.org/project/gitlab_templates/-/blob/main/docs/job...

comma separated :)

Since filter modules deal with input text vs rendered text, writing functional tests could be helpful for regressions. I did this for freelinking. The only coverage I have in Unit (or Kernel) tests for that module is around tips output. Although I also have a plugin architecture that I have unit tests for.

I'll settle for *a* test of any kind to get this kick-started ;)

I've cherry-picked the lenient variable commit into 2.x to get the build step green. The rest of this MR remains uncommitted.

I wrote a really basic kernel test and pushed this to the active MR branch.

The previous test that was there I put this in a backup branch so it's not lost, https://git.drupalcode.org/issue/token_filter-3433144/-/tree/3433144-cre...

Looks like the WIP test is still part of the MR. If we can tidy that up I can close this then open some follow-ups for other tests.

Oops! Git fail. Fixed.

Test is proof that the text replacement happens. Gotta start somewhere :)

Looks good to me. Thanks @sime!

Automatically closed - issue fixed for 2 weeks with no activity.