PHPStan - enable and fix

Notes

Phpstan couldn't find the base class in core (because it was removed in drupal 10). I see this module supports D10 so I just removed the class.

One issue i haven't been able to resolve yet.

When testing against next version (ie D11) PHPstan fails because a CKEditor 4 related class dependency no longer exists.

In this discussion it was suggested we haven't quite solved the best way to do this.

I have removed the "next version" test in this PR for now (so that is it all green), and happy for further direction - ie would you accept a bunch of stubs to make this work? Or do you want to wait for some other solutions to emerge.

Note that if just the PHPstan NEXT_MAJOR is "warning" (orange) the project page would still show that CI is "pass" (green).

#5: The class was moved to a contrib module but that module is no longer supported either, so yes, removing that class is best, thanks.

#6: I'm happy for next_major to be orange if the project page is green.

There's a bunch of conflicts now that 📌 PHPCS - enable and fix Fixed is in, I wasn't expecting that. Do you want to fix the merge conflict or should I have a go?

Yes I will fix 👍

Ok that's ready with the one orange. I'd be interested to see what the status shows when that is merged.

Here goes nothing, and if it does remain orange I'll just turn off next_major with a postponed follow-up until it's resolved.

Looks good:

Automatically closed - issue fixed for 2 weeks with no activity.