Removed deprecated code in core/tests/Drupal/KernelTests

These are testing deprecated functions in core. If we remove the test coverage the functions they go to should also be removed.

@smustgrave, can you be more specific about what functions need to be removed? I don't see that being applicable here.

That was my mistake. Believe I had a similar ticket up at the time but deprecation tests appear to be for tests traits.

Committed/pushed to 11.x, thanks!

I messed up here and never pushed the commit, and now there are conflicts. Just pushed a rebase to get this going again.

The rebase needs some work.

Either the original MR missed a deprecation removal or we added new deprecations after this was done.

Had to fix FileSaveUpload test which wasn't updated with the KernelTestBase session changes, and remove one legacy method on KernelTestBaseTest

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Should be better.

FileSaveUploadTest doesn't fail for me running with phpunit locally and also doesn't fail on gitlab... which I just realised is 'fine' because it's @legacy in its own right so allowed to trigger deprecation errors. Maybe could have just removed the method here but feels a bit out of scope to do that too.

The remaining instances of "deprecated" in this folder belong to deprecations in lib folder and will be removed with those ticket removals. So believe this is good.

Committed 5637aff and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.