- Issue created by @alexpott
- Status changed to Needs review
about 1 year ago 10:19am 20 March 2024 - Status changed to RTBC
about 1 year ago 2:29pm 20 March 2024 - 🇺🇸United States smustgrave
Based on the description of what this does
Disables using the /dev/shm shared memory file system, which may reduce memory usage during testing.
This is being removed for performance reasons.
On that assumption don't see an issue with removal.
- Status changed to Needs review
about 1 year ago 2:38pm 20 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
I thought it was going to make the tests about twice as quick - it did in the past and I can not explain why now.
- 🇺🇸United States smustgrave
@alexpott any recommended way for testing this?
- 🇬🇧United Kingdom longwave UK
This affects the way Chrome runs inside Docker so as long as all the functional JavaScript tests pass - locally as well as on CI if possible - then I think we are good.
- 🇺🇸United States smustgrave
So should this be RTBC? Or should the tests be ran a few times to make sure nothing random pops up
- 🇺🇸United States byrond
This option has been shown in the past to prevent Chrome from crashing during JavaScript tests. Are you sure there won't be any negative side-effects for removing it?
- Status changed to Needs work
about 1 year ago 8:44am 29 March 2024 - 🇬🇧United Kingdom longwave UK
The IS doesn't explain why we would change this. #5 says there should be a performance increase but that doesn't seem to be the case, if there is no issue to solve should we just leave it alone?
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
In some ways we need to explain why there is not a performance improvement :)