- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β these changes make this module compatible with Drupal 11! π
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
- First commit to issue fork.
-
rklawson β
committed 9a4c371a on 1.0.x
Issue #3431566: Add to the dictionary that cspell uses in pipelines due...
-
rklawson β
committed 9a4c371a on 1.0.x
-
rklawson β
committed b943c65c on 1.0.x
Issue #3431566: Correct misspelling flagged by cspell checker in...
-
rklawson β
committed b943c65c on 1.0.x
-
rklawson β
committed e7002321 on 1.0.x
Issue #3431566: Switch to dependency injection for entity type manager.
-
rklawson β
committed e7002321 on 1.0.x
-
rklawson β
committed b7b155b9 on 1.0.x
Issue #3431566: Add phpstan.neon file with configuration to ignore...
-
rklawson β
committed b7b155b9 on 1.0.x
- πΊπΈUnited States rklawson
I confirmed that the module's functionality is working on Drupal 11 dev, but there are also some failing tests.
Updates/fixes
- Added phpstan.neon file to ignore unsafe usage of new static() errors, since using them is a Drupal best practice. See https://www.drupal.org/docs/develop/development-tools/phpstan/handling-u... β for more context.
- Implemented dependency injection instead of relying on \Drupal.
- Corrected a misspelling (viewmode vs. view mode) flagged by cspell.
- Added to the cspell dictionary to account for other errors.
The pipeline now passes: https://git.drupalcode.org/project/layout_builder_additions/-/pipelines/..., and local testing was still working correctly, so I merged the PR after the additional commits to fix issues.
- πΊπΈUnited States rklawson
Updates
- Released https://www.drupal.org/project/layout_builder_additions/releases/1.0.5 β with these changes.
Next Steps
- Leaving this issue open, per the ticket description, since the bot may come through with further recommendations as tools are improved and Drupal 11 continues development.. It looks like I should have used a separate branch for my fixes, but since they're merged, I think everything will be fine.
- Status changed to Active
11 months ago 8:03pm 19 March 2024 - Status changed to Fixed
4 months ago 11:03pm 7 November 2024