Account created on 1 November 2008, about 16 years ago
  • Associate Director of Technology at Evolving WebΒ  …
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States rklawson

Sorry for the delay in reviewing this. It worked for me as well. Thanks for fixing, Seth, and thank you for merging, Marcus!

πŸ‡ΊπŸ‡ΈUnited States rklawson

Updates

Next Steps

  • Leaving this issue open, per the ticket description, since the bot may come through with further recommendations as tools are improved and Drupal 11 continues development.. It looks like I should have used a separate branch for my fixes, but since they're merged, I think everything will be fine.
πŸ‡ΊπŸ‡ΈUnited States rklawson

I confirmed that the module's functionality is working on Drupal 11 dev, but there are also some failing tests.

Updates/fixes

  • Added phpstan.neon file to ignore unsafe usage of new static() errors, since using them is a Drupal best practice. See https://www.drupal.org/docs/develop/development-tools/phpstan/handling-u... β†’ for more context.
  • Implemented dependency injection instead of relying on \Drupal.
  • Corrected a misspelling (viewmode vs. view mode) flagged by cspell.
  • Added to the cspell dictionary to account for other errors.

The pipeline now passes: https://git.drupalcode.org/project/layout_builder_additions/-/pipelines/..., and local testing was still working correctly, so I merged the PR after the additional commits to fix issues.

πŸ‡ΊπŸ‡ΈUnited States rklawson

Hi @mortona2k,

Thanks for the additional feedback.

There is also Layout Builder Operation Link that provides that layout operation in the content listing.

That's a newer project that focuses just on that functionality. It looks like it was created 14 Sep 2022 vs. 11 Mar 2021 for this project.

I added the information about the core issue toward the bottom of the description for this project, since that's good to know, and it's now right after the part of the description that talks about that functionality.

This also says it enhances the block entry in layout builder. I see the title field and checkbox in the images, but it's not clear what the difference is. Could you add something about the use case please?

The reason for this is that the screenshots showed what the module is doing vs. doing a comparison. They showed what it looked like in core Layout Builder and also in a modal when Layout Builder Modal (which is recommended) is installed.

I understand how that can be confusing. In the past, there was more information (and images) in the description, but it was a little unwieldy, because at the time, I didn't realize that files could be used instead of images. So I reverted back to that older version and then cleaned up those screenshots a bit. I may need to update the screenshots for D10, since I took those in D9.

In any case, for right now, I reverted the page back to an earlier version and then cleaned up the images a bit. Hopefully that will help clarify things a bit, but let me know if you're still seeing anything confusing. You'll probably appreciate the before/after for the blocks.

πŸ‡ΊπŸ‡ΈUnited States rklawson

Closing this out as completed, since it has been open without any further responses for many months.

The project description was also updated to clarify after this issue was opened to add more clarity.

πŸ‡ΊπŸ‡ΈUnited States rklawson

Hi @mortona2k,

When you have either of these two options enabled for a content type, you get an option to access the Layout right from the content admin section (/admin/content):

  • Use Layout Builder
  • Allow each content item to have its layout customized.

Here's what that looks like:

It also simplifies the UI when you're adding blocks in Layout builder.

Here's what that looks like:

I hope this helps and the images load for you.

They're loading for me under the project description, bit there used to be more of them, so I fixed the language to refer to the last two instead of four images.

πŸ‡ΊπŸ‡ΈUnited States rklawson

Closing this out as fixed.

πŸ‡ΊπŸ‡ΈUnited States rklawson

Updates

  • Resolved the phpcs error. Pipelines now fully pass.
  • Dropped Drupal 8 support in the info.yml file.
πŸ‡ΊπŸ‡ΈUnited States rklawson

Closing this out as fixed.

πŸ‡ΊπŸ‡ΈUnited States rklawson

The file has been added as .gitlab-ci.yml, and pipelines are now running in GitLab:
https://git.drupalcode.org/project/layout_builder_additions/-/pipelines

πŸ‡ΊπŸ‡ΈUnited States rklawson

Drop reference to Drupal 8 and clarify that the module is currently available for both Drupal 9 and Drupal 10.

Production build 0.71.5 2024