Contrib.social

Fix / Adjust tests, schema, configuration and more

Open on Drupal.org →
Created on 18 March 2024, 9 months ago
Updated 4 April 2024, 9 months ago

Problem/Motivation

EDIT: While going through all the submodule tests, we found quite a few missing schema errors, incorrect / missing configuration and other miscallenous fixes. Since these all depended on each other, it was easier to fix them all inside one giant MR.

Important fixes:

  • Lock all fields through the field_storage definition
  • Fix / Add missing schema defintions
  • Introduce GenericDrowlParagraphsBsTestBase
  • Fix main and submodule tests
  • Fix field.field.paragraph.xxx.field_settings.ymls "default_value" entries
  • Correct submodule dependencies
  • Fix duplicate drowl_paragraphs_bs_type_score configs, which were present in both "install" and "optional"

Original Summary:

Tests in submodules currently fail and I think it's because the modules are not being disabled in the submodule tests?

They are already present in the dependencies

There were 24 errors:
1) Drupal\Tests\drowl_paragraphs_bs_type_anchor\Functional\GenericDrowlParagraphsBsAnchorTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_anchor' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
2) Drupal\Tests\drowl_paragraphs_bs_type_attachments\Functional\GenericDrowlParagraphsBsAttachementsTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_attachments' is missing its dependency module entity_reference_display.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
3) Drupal\Tests\drowl_paragraphs_bs_type_block_content\Functional\GenericDrowlParagraphsBsBlockContentTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_block_content' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
4) Drupal\Tests\drowl_paragraphs_bs_type_button\Functional\GenericDrowlParagraphsBsButtonTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_button' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
5) Drupal\Tests\drowl_paragraphs_bs_type_card\Functional\GenericDrowlParagraphsBsCardTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_card' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
6) Drupal\Tests\drowl_paragraphs_bs_type_countdown\Functional\GenericDrowlParagraphsBsCountdownTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_countdown' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
7) Drupal\Tests\drowl_paragraphs_bs_type_entity_reference\Functional\GenericDrowlParagraphsBsEntityReferenceTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_entity_reference' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
8) Drupal\Tests\drowl_paragraphs_bs_type_gallery\Functional\GenericDrowlParagraphsBsGalleryTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_gallery' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
9) Drupal\Tests\drowl_paragraphs_bs_type_icon\Functional\GenericDrowlParagraphsBsIconTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_icon' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
10) Drupal\Tests\drowl_paragraphs_bs_type_image\Functional\GenericDrowlParagraphsBsImageTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_image' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
11) Drupal\Tests\drowl_paragraphs_bs_type_image_text\Functional\GenericDrowlParagraphsBsImageTextTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_image_text' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
12) Drupal\Tests\drowl_paragraphs_bs_type_layout\Functional\GenericDrowlParagraphsBsLayoutTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_layout' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
13) Drupal\Tests\drowl_paragraphs_bs_type_layout_restricted_access\Functional\GenericDrowlParagraphsBsRestrictedAccessTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_layout_restricted_access' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
14) Drupal\Tests\drowl_paragraphs_bs_type_layout_slideshow\Functional\GenericDrowlParagraphsBsLayoutSlideshowTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_layout_slideshow' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
15) Drupal\Tests\drowl_paragraphs_bs_type_markup\Functional\GenericDrowlParagraphsBsMarkupTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_markup' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
16) Drupal\Tests\drowl_paragraphs_bs_type_score\Functional\GenericDrowlParagraphsBsScoreTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_score' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
17) Drupal\Tests\drowl_paragraphs_bs_type_simple_map\Functional\GenericDrowlParagraphsBsSimpleMapTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_simple_map' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
18) Drupal\Tests\drowl_paragraphs_bs_type_slideshow\Functional\GenericDrowlParagraphsBsSlideshowTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_slideshow' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
19) Drupal\Tests\drowl_paragraphs_bs_type_tabs_accordion\Functional\GenericDrowlParagraphsBsTabsAccordionTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_tabs_accordion' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
20) Drupal\Tests\drowl_paragraphs_bs_type_text\Functional\GenericDrowlParagraphsBsTextTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_text' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
21) Drupal\Tests\drowl_paragraphs_bs_type_video\Functional\GenericDrowlParagraphsBsVideoTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_video' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
22) Drupal\Tests\drowl_paragraphs_bs_type_view\Functional\GenericDrowlParagraphsBsViewTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_view' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
23) Drupal\Tests\drowl_paragraphs_bs_type_webform\Functional\GenericDrowlParagraphsBsWebformTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs_type_webform' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
24) Drupal\Tests\drowl_paragraphs_bs\Functional\GenericDrowlParagraphsBsTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'drowl_paragraphs_bs' is missing its dependency module fences.
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:153
/builds/project/drowl_paragraphs_bs/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/drowl_paragraphs_bs/web/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:40
/builds/project/drowl_paragraphs_bs/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
ERRORS!
Tests: 24, Assertions: 48, Errors: 24.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024