Replace func_get_args with variable-length argument in FormBuilder

Committers can you please move credit from 📌 Replace func_get_args with variable-length argument in FormBuilder Needs review .

Refactoring seems fine.

Question was there a change record for when it was first added? Don't know if the CR should be updated to include this ticket? Not sure policy on that

Adding related issues. The change was prepared in 📌 Prepare FormBuilder for variadic functions Fixed , the CR there is generic though. Do we need a separate CR?

I would say probably not. Not sure if this issue should be added to the published CR. Will lean on a committer for that one.

Yes we should have a dedicated change record for this one given it's an interface change and because the previous CR was for how to deprecate, not the deprecation itself, we can't add it onto that one.

Added CR

catch → credited alexpott → .

catch → credited jidrone → .

catch → credited longwave → .

catch → credited xjm → .

@mondrake fwiw it should have been possible to open a new branch with a new MR for 📌 Replace func_get_args with variable-length argument in FormBuilder Needs review but since this is now a follow-up for another issue I think it's OK to continue here anyway.

Thanks for the CR. Committed/pushed to 11.x, thanks!

#17 @catch I tried that - but the original fork was so old it did not have the 11.x branch reference, so I could not create a new branch against that. What would be the process in that case, is that documented anywhere? Thx

@mondrake assuming origin is the core repo you can do

$ git fetch origin 11.x
$ git push drupal-1234567 11.x

to mirror 11.x from core into the fork, and then raise MRs against it

#19 great thanks

mondrake → closed merge request !7075

Automatically closed - issue fixed for 2 weeks with no activity.