Automated Drupal 11 compatibility fixes for entity_usage

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.7
3. palantirnet/drupal-rector: 0.20.1

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.10
3. palantirnet/drupal-rector: 0.20.1

Balu Ertl → made their first commit to this issue’s fork.

Balu Ertl → changed the visibility of the branch project-update-bot-only to hidden.

Based on the answers on this Slack thread, I have the conclusion that it's not strictly necessary to rely on the DeprecationHelper::backwardsCompatibleCall() utility. I assume the module maintainers probably still plan to continue supporting D9, in which this deprecation handling solution was not present yet and thus would have no effect anyway.

Although the change record → about the deprecation of watchdog_exception() suggests using \Drupal\Core\Utility\Error::logException() but for me, it still seems to be just another wrapper around the \Drupal\Core\Logger\LoggerChannel::log().

Therefore I simplified exception logging with a more informative solution I peeked from core's \Drupal\Core\EventSubscriber\DefaultExceptionHtmlSubscriber::makeSubrequest(). As both methods are marked as static, thus we cannot rely on the central dependency injection to obtain a logger channel service.

Ready for review.

Did quite a bit of work on this. Tests are all green now on all enabled core versions.

* Opt-in for next minor and major, previous minor and concurrent testing (speeds up phpunit job from 5min to 2min). Personally, I recommend removing next minor/major testing from CI, because it's unlikely that merge requests will break future versions (unlike previous minor (and major, once D11 is out), instead, what I do is set up a "next" weekly schedule with both of those enable, because if things break here it's because core changes.
* Workaround for mysql errors around triggers with DER, should be fixed in gitlab templates soon as well.
* workarounds for testing on next major with various test dependencies that aren't compatible yet
* Various test fixes, mostly those tests already failed at least since 10.3 too
* Removed image_upload test config, it's disabled anyway but caused weird schema errors.
* reduced previous changes around entity storage and also logging. really no need to have an exception *and* an assert() and a @var docblock. Seems fair to have an assert, but a revisionable entity type must have a revisionable storage or it would not work at all.

Thank you for working on this! 🙏
I agree on the testing strategy you mentioned. Just removed the next minor/major and added the scheduled pipeline to be run weekly (thanks for the suggestion).
However, this run now failed, with error:

There was 1 failure:
    
    1) Drupal\Tests\entity_usage\Functional\Update\UpdateTest::testUpdate8206
    Failed to run installer database tasks: Database drupal not found. The
    server reports the following message when attempting to create the
    database: SQLSTATE[HY000]: General error: 1007 Can't create database
    'drupal'; database exists., Failed to CREATE a test table on your database
    server with the command CREATE TABLE {drupal_install_test} (id int NOT NULL
    PRIMARY KEY). The server reports the following message: SQLSTATE[3D000]:
    Invalid catalog name: 1046 No database selected: CREATE TABLE
    "test56035940drupal_install_test" (id int NOT NULL PRIMARY KEY); Array
    (
    )
    .Are you sure the configured username has the necessary permissions to
    create tables in the database?
    
    /builds/project/entity_usage/web/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php:226
    /builds/project/entity_usage/web/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php:141
    /builds/project/entity_usage/web/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php:113
    /builds/project/entity_usage/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
    /builds/project/entity_usage/web/core/tests/Drupal/FunctionalTests/Update/UpdatePathTestBase.php:92
    /builds/project/entity_usage/tests/src/Functional/Update/UpdateTest.php:41
    /builds/project/entity_usage/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
    
    FAILURES!
    Tests: 1, Assertions: 1, Failures: 1.
---- Drupal\Tests\entity_usage\Functional\EntityUsageLayoutBuilderTest ----

Does this ring any bell for you? Has anything changed in CI between yesterday and today? :) 🤔

OK, all green, I'm merging this.
Thanks again for working on this!

Automatically closed - issue fixed for 2 weeks with no activity.