Contrib.social

Automated Drupal 11 compatibility fixes for ckeditor5_font

Open on Drupal.org →
Created on 16 March 2024, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

1.1

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment about 1 year ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-120835

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !7Automated Project Update Bot fixes → (Open) created by project update bot
  • Comment 4 months ago →
    🇺🇸United States Shefik

    Patch #2 applied successfully.

  • First commit to issue fork.
  • Merge request !10Drupal 11 compatibility → (Open) created by Unnamed author
  • Comment 4 months ago →
    🇮🇳India manishvaity

    MR!10 Makes this module compatible with Drupal 11. Functionality is working as expected.

    RTBC +1

  • Comment 4 months ago →
    🇨🇦Canada superfedya

    Doesnt work for me.

    Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "ckeditor5_codeBlock" CKEditor 5 plugin definition is configurable, has non-empty default configuration but has no config schema. Config schema is required for validation. in Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition->validateDrupalAspects() (line 186 of /var/www/html/web/core/modules/ckeditor5/src/Plugin/CKEditor5PluginDefinition.php).

  • Status changed to RTBC about 2 months ago
  • Comment about 2 months ago →
    🇫🇷France Fabsgugu
  • Comment about 1 month ago →
    🇮🇳India manojkumar_97

    @superfedya i'm also getting same error after apply MR10

    Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "ckeditor5_codeBlock" CKEditor 5 plugin definition is configurable, has non-empty default configuration but has no config schema. Config schema is required for validation. in Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition->validateDrupalAspects() (line 186 of core/modules/ckeditor5/src/Plugin/CKEditor5PluginDefinition.php).

  • Comment about 1 month ago →
    🇫🇷France dydave

    Looks like this is being blocked by 🐛 Error after update to Drupal 10.1.0 Active .

    If you'd like the patch to work, it should include the fix from issue 🐛 Error after update to Drupal 10.1.0 Active .

    Ideally, the patch from the other issue should be merged first, then rebase this patch and it should go through nicely.
    In other words, there shouldn't be any more changes to make to this MR to fix this.

    Otherwise, if you're trying to fix this issue in your project you would need both patches applied to the module.

    Could somebody please try testing this and report back?

    Thanks in advance.

  • Comment 16 days ago →
    🇹🇷Turkey makbay

    @dydave I tested with both patches applied on Drupal 11.1.6

    There is another thing to be resolved, see attached image.

  • Comment 16 days ago →
    🇫🇷France dydave

    Thanks @makbay!

    I didn't see this: 📌 Deprecate in favor of the CKEditor 5 Plugin Pack RTBC

    Please don't use this module anymore it should be marked deprecated.

    Maintainers have agreed to move developments to contrib module CKEditor 5 Plugin Pack → , which now provides the same features.

    This issue is most likely never going to get fixed and so are all other issues in the project's tracker.

    This module should be considered as Abandoned.

  • Comment 15 days ago →
    🇹🇷Turkey makbay

    Yeah, I also switched to that one eventually.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024