Automated Drupal 11 compatibility fixes for boost

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.7
3. palantirnet/drupal-rector: 0.20.1

For everybody who already want's the small change +core_version_requirement: ^9 || ^10 || ^11 to info file. Please first help to get this module stable on D10.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.2.0
2. mglaman/phpstan-drupal: 1.2.10
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.1
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.1
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.1

joseph.olstad → made their first commit to this issue’s fork.

c-logemann → closed merge request !16

The MR created by the bot was based on a wrong branch so I closed that one because !17 is also there.

Thanks @joseph.olstad for creating a fresh one and adding the patch of the bot.

For testing via composer.

Install patch management:
composer require cweagans/composer-patches

For using D10 projects in D11 :
composer require mglaman/composer-drupal-lenient

Add to "extra" section in main composer.json:

   "drupal-lenient": {
            "allowed-list": [
                "drupal/boost"
            ]
        },
        "patches": {
            "drupal/boost": {
                "Automated Drupal 11 compatibility fixes for boost, #3428282": "https://www.drupal.org/files/issues/2024-05-30/boost.1.x-dev.rector.patch"
            }
        },

To get the automated patch working, we need the dev version.
composer require drupal/boost:1.x-dev@dev

I tried to install in a fresh Core 11.1.1 after drush site:install demo_umami with drush en boost and got this error:

TypeError: Drush\Commands\DrushCommands::logger(): Return value must be of type ?Drush\Log\DrushLoggerManager, Drupal\Core\Logger\LoggerChanne  
  l returned in Drush\Commands\DrushCommands->logger() (line 77 of /var/www/h-kee7x/dev/dyn/boost/vendor/drush/drush/src/Commands/DrushCommands.  
  php). 

Additionally on Config page admin/config/development/performance/boost there is this error:

ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in web/modules/contrib/boost/src/Form/BoostSettingsForm.php on line 72 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 44 of core/lib/Drupal/Core/Form/ConfigFormBase.php).

I believe this errors are not limited to D11 but should be fixed in other Issues.

I added child Issues for fixing:

• 🐛 ypeError: DrushCommands::logger() Active
• 🐛 ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct() Active

After the fixing of both issues above I tried as next step with demo_umami to crawl with "node: article, page, recipes" and got this error:
Deprecated function: Creation of dynamic property Drupal\boost\BoostCacheGenerate::$config is deprecated in Drupal\boost\BoostCacheGenerate->__construct() (line 53 of modules/contrib/boost/src/BoostCacheGenerate.php).

Added next child issue: 🐛 Crawling broken on D11 Active

Ah yes the dynamic property! Love those!