- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-120024This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-137198These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.10
- palantirnet/drupal-rector: 0.20.1
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- π¦πΊAustralia interlated
From Upgrade Status
web/modules/patched/bibcite/modules/bibcite_entity/config/optional/views.view.bibcite_contributor.yml 287 Support from all Views contextual filter settings for the default_argument_skip_url setting is removed from drupal:11.0.0. No replacement is provided. See https://www.drupal.org/node/3382316 β .
The change says remove it
"The Views setting default_argument_skip_url has been removed from all Views contextual filter settings. This setting has never worked and provided no clear use case that needed support in Drupal core.
- First commit to issue fork.
- πΊπΈUnited States mark_fullmer Tucson
To better establish that this is functionally compatible with Drupal 11, I added a generic
.gitlab-ci.yml
template to the existing merge request. Based on the output -- see https://git.drupalcode.org/issue/bibcite-3428258/-/jobs/3511898 -- there is still a significant amount of work to do here to make this D11 compatible.Setting to "Needs work."
- πΊπΈUnited States mark_fullmer Tucson
I worked through a number of D11 compatibility issues and got this merge request to a point where I think the remaining problems have to do with dependencies:
1. Failing test
bibcite_entity/tests/src/Kernel/EntityCitationRenderTest
outputsTypeError: htmlspecialchars(): Argument #1 ($string) must be of type string, array given
, which is potentially due to a problem in the dependency seboettg/citeproc-php. See https://github.com/seboettg/citeproc-php/issues/184
2. Additionally, it appears that some logic has changed in Drupal's denormalizer: bibcite_import is not importing data in the way it did in Drupal 10 at/admin/content/bibcite/reference/import
, withSymfony\Component\Serializer\Exception\UnexpectedValueException: Could not determine entity type bundle: "type" field is missing. in Drupal\serialization\Normalizer\EntityNormalizer->extractBundleData() (line 115 of /core/modules/serialization/src/Normalizer/FieldableEntityNormalizerTrait.php).
. This can be reproduced in the UI.At this point, probably a maintainer needs to weigh in.
- Status changed to Needs work
24 days ago 4:39pm 13 March 2025 - First commit to issue fork.
- πΊπΈUnited States mmarler
This is ready for a functional review. Still working on getting the tests to pass.
- πΊπΈUnited States mmarler
Note for the maintainers: In Drupal 11, Symfony's denormalize method was using the wrong denormalizer provided by Bibcite. For example, when using the populate reference form to add a BibTeX reference, Symfony would return Bibcite's
ContributorNormalizer
class instead of theBibtexReferenceNormalizer
class. After setting theBibtexReferenceNormalizer
service to a higher priority, Symfony returned the correct class.Additionally, calls to
$this->serializer->denormalize
inReferenceNormalizer
andBibtexReferenceNormalizer
would fail to create contributor and keyword entities. Changing these to use Drupal's denormalizer seems to fix that issue.If you approve of these changes, please consider creating a new release. Thanks!