Automated Drupal 11 compatibility fixes for amp

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.7
3. palantirnet/drupal-rector: 0.20.1

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.10
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.3

MR!22 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1

The drupal/amp module is still not compatible with Drupal 11 due to its dependencies in composer.json. It requires: "lullabot/amp": "^1.1 || ^2.0.4" (PHP >=5.6). The latest stable version of lullabot/amp is 2.1.1, followed by dev-main, but even these still require PHP >=5.6. As long as this does not change, the drupal/amp module will not be compatible with Drupal 11.

I can confirm that the MR applies BUT i can also confirm what @elisur says: Even with this MR applied, you cant use this module in your D11 project because of the version requirement of lullabot/amp. That should be updated as well.

This is the only module blocking the update to D11 in this project.

Will it work if the required lullabot/amp version gets updated in the MR ?
Maybe "lullabot/amp": "^1.1 || ^2.0.4", should become "lullabot/amp": "^1.1 || ^2.0.4 || ",

Adding this in my repositories section in my composer.json file helped me (thanks to #3325977 🐛 php 8.1 - lullabot/amp seems abandoned: replace abandoned querypath/querypath with gravitypdf/querypath Active ):

{
            "type": "package",
            "package": {
                "name": "lullabot/amp",
                "version": "2.0.4",
                "type": "composer",
                "source": {
                    "type": "git",
                    "url": "https://github.com/deimosindustries/amp-library.git",
                    "reference": "6a3074586ead73cd47cb4fc4e2c429df19fcc2b6"
                }
            }
        },

with this added in + adding this issue via drupal lenient, I was able to upgrade my project to D11.

After upgrading the project to D11 this way, I got this error in status reports:
AMP
Not available
The AMP module requires the PHP AMP library.

So this still needs work.

I was able to upgrade to D11 thanks to comment #13 📌 Automated Drupal 11 compatibility fixes for amp Active from @flyke → and I am at the same point, that is, once in D11 I get the same error in status report #14 📌 Automated Drupal 11 compatibility fixes for amp Active .

I've made some changes on my composer.json:

Added the lullabot/amp repository in my composer.json with this fork (with the library's composer.json updated to PHP >= 8 and all its dependencies too:

            "type": "package",
            "package": {
                "name": "lullabot/amp",
                "version": "2.0.4",
                "type": "composer",
                "source": {
                    "type": "git",
                    "url": "https://github.com/zunderbolt/amp-library.git",
                    "reference": "eb28b130c70db00516b578c5a1d07301b637c222"
                }
            }

Added autoload:

    "autoload": {
        "psr-4": {
            "Lullabot\\AMP\\": "vendor/lullabot/amp/src/"
        }
    },

Added patch:

            "lullabot/amp": {
                "#317": "https://patch-diff.githubusercontent.com/raw/Lullabot/amp-library/pull/317.patch"
            }

Then after updating composer I've disabled and enabled the amp module with Drush, clear cache and it works fine on Drupal 11 on my site.

I still cant get rid of the The AMP module requires the PHP AMP library. error.
Am I still missing something ?

In composer require section I have:
"drupal/amp": "3.x-dev@dev"
and also, just as test because should automatically be present:
"lullabot/amp": "^2.0"

my composer merge-plugin section:

        "merge-plugin": {
            "include": [
                "core/composer.json",
				 "vendor/lullabot/amp/composer.json"
            ],
            "recurse": false,
            "replace": false,
            "merge-extra": false
        },

In my composer patches section:

            "drupal/amp": {
                "#3428159 D11": "https://git.drupalcode.org/project/amp/-/merge_requests/22.diff"
            }

In my composer drupal-lenient section:

        "drupal-lenient": {
            "allowed-list": [
                "drupal/amp"
            ]
        }

In my composer repositories section as first repository:

        {
            "type": "package",
            "package": {
                "name": "lullabot/amp",
                "version": "2.0.4",
                "type": "library",
                "source": {
                    "type": "git",
                    "url": "https://github.com/elisurrc/amp-library.git",
                    "reference": "5cedfc1fee71192c8679b7c30c4e46c63af6af9b"
                }
            }
        },

Hi @flyke → ,

I have the elisurrc repository as the last. Also in the require section I have: "drupal/amp": "^3.8"

Also check your vendor/lullabot/amp/ folder because if you have already that folder before changing the repository in composer.json, the composer install command doesn't overwrite it. Look at the vendor/lullabot/amp/composer.json file to check you have there the right repo. If it is not the good one just delete the vendor/lullabot folder and rerun composer install.