- Issue created by @mr.pomelov
You have to update both gin and gin toolbar
composer require drupal/gin_toolbar:^1.0@rc drupal/gin:^3.0@rc
fixed mine that way without roling back- Status changed to Active
8 months ago 9:57am 21 March 2024 - π«π·France Grimreaper France π«π·
Hi,
This service had been introduced in 1.0.0-rc6: https://git.drupalcode.org/project/gin_lb/-/compare/1.0.0-rc5...1.0.0-rc...
I have not encountered the problem because I always do my updates with CLI: Composer + Drush (updb) and clearing cache with Drush everytime.
I think an update hook to ensure container cache are flushed needs to be implemented. But if the error also prevents to access update.php, for people using update.php to do their updates, update hook or not it will not be possible to execute the update hook I guess. Or if an update hook is present, update.php will be ok.
- π«π·France Grimreaper France π«π·
I have tested and being able to reproduce the bug.
Asked on Slack the best way to solve this.
If there is a better solution than having optional service. And how to clear the cache.
- Assigned to Grimreaper
- Merge request !84Issue #3427805 by Grimreaper, mr.pomelov: You have requested a non-existent... β (Merged) created by Grimreaper
- π«π·France Grimreaper France π«π·
Link to Slack question and answers: https://drupal.slack.com/archives/CJ93UNJP4/p1711028844896989
Following it, I have created a MR with the update hook that will just invalide the service container: https://git.drupalcode.org/project/gin_lb/-/merge_requests/84
Unfortunately, I am not able to get the fatal error anymore on the update.php. I witnessed it, but I am not sure of the conditions to reproduce it.
Here are some screenshots of the hooks called during the display of update.php. to see the stacktrace.
I will try to make the service optional to ease the update.
- Status changed to Needs review
8 months ago 10:46am 22 March 2024 - π«π·France Grimreaper France π«π·
I don't understand PHPStan https://git.drupalcode.org/project/gin_lb/-/jobs/1129623:
Negated boolean expression is always false.
- Issue was unassigned.
- πΊπΈUnited States mglaman WI, USA
Grimreaper β credited mglaman β .
- π«π·France Grimreaper France π«π·
Thanks to @mglaman for the reply on Slack.
Until https://github.com/mglaman/phpstan-drupal/issues/668 is fixed it is normal to ignore the PHPStan error.
- Status changed to RTBC
7 months ago 6:24am 18 April 2024 - π¨π¦Canada joelpittet Vancouver
Thanks @Grimreaper, this allowed me to deploy after this change without a 500 error regarding that missing service.
-
Grimreaper β
committed 4035038a on 1.0.x
Issue #3427805 by Grimreaper, mr.pomelov, joelpittet, mglaman: You have...
-
Grimreaper β
committed 4035038a on 1.0.x
- Status changed to Fixed
7 months ago 8:21am 18 April 2024 - π«π·France Grimreaper France π«π·
Thanks @joelpittet for the RTBC.
Merged.
I will try to do another issue before asking for a new release to unblock people.
Automatically closed - issue fixed for 2 weeks with no activity.