- Issue created by @bwaindwain
- Status changed to Needs review
9 months ago 12:50am 12 March 2024 - Merge request !108Issue #3427213 by bwaindwain, Anybody, Grevil: Images (media) using blazy are being blocked → (Merged) created by bwaindwain
- Assigned to Grevil
- Issue was unassigned.
- Status changed to Needs work
9 months ago 4:01pm 15 March 2024 - 🇩🇪Germany Grevil
This will fail, as soon as we use any other media type (bundle) which also uses a video field but isn't named "video". E.g. the core media type "remote_video" wouldn't get blocked as well as any custom media type with a video field.
- 🇩🇪Germany Anybody Porta Westfalica
I can confirm this regression. We'll fix this immediately.
- 🇩🇪Germany Anybody Porta Westfalica
The reason is indeed that
blazy_media
formatter was added in 🐛 Videos are not being blocked when using blazy_oembed formatter and add support for "blazy_media" formatter Fixed
https://git.drupalcode.org/project/cookies/-/blob/1.2.x/modules/cookies_...but that affects all media types, not only videos. So we need a limitation to videos.
@Grevil is right n #6 that that hard coded workaorund will just work for core media type namings. So we should instead better check for the media being used.
blazy_media acts on all entity references:
* @FieldFormatter( * id = "blazy_media", * label = @Translation("Blazy Media"), * field_types = { * "entity_reference", * } * )
with this condition:
/** * {@inheritdoc} */ public static function isApplicable(FieldDefinitionInterface $field_definition) { return $field_definition->getFieldStorageDefinition()->getSetting('target_type') == 'media'; }
- Status changed to Needs review
9 months ago 9:28am 18 March 2024 - Status changed to RTBC
9 months ago 9:35am 18 March 2024 -
Grevil →
committed 935b3454 on 1.2.x authored by
bwaindwain →
Issue #3427213 by bwaindwain, Anybody, Grevil: Images (media) using...
-
Grevil →
committed 935b3454 on 1.2.x authored by
bwaindwain →
- Status changed to Fixed
9 months ago 9:53am 18 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.