- Issue created by @eng-deveco
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPractice
on the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
- If you have not done it yet, you should run
- Status changed to Needs work
9 months ago 9:30am 12 March 2024 - 🇮🇳India rushiraval
This module is for Drupal 9 and 10 but you requires php 7.4 in info.
Drupal 10 Requires php 8.1 and above. Please refer
https://www.drupal.org/docs/getting-started/system-requirements/overview
- Status changed to Needs review
9 months ago 10:09am 12 March 2024 - 🇮🇳India vishal.kadam Mumbai
@Rushikesh Raval
php: 7.4
defines the minimum PHP version required for the module, not the exact version. - Status changed to Needs work
9 months ago 11:35am 12 March 2024 - 🇮🇳India rushiraval
Please solve the following phpcs Error
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/drupal-cache/
FILE: web/modules/contrib/drupal-cache/README.md
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
13 | WARNING | [ ] Line exceeds 80 characters; contains 632 characters
19 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
30 | WARNING | [ ] Line exceeds 80 characters; contains 253 characters
32 | WARNING | [ ] Line exceeds 80 characters; contains 420 characters
34 | WARNING | [ ] Line exceeds 80 characters; contains 422 characters
36 | WARNING | [ ] Line exceeds 80 characters; contains 220 characters
36 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------FILE: web/modules/contrib/drupal-cache/src/MomentoCacheBackendFactory.php
---------------------------------------------------------------------------------------------------------
FOUND 36 ERRORS AFFECTING 26 LINES
---------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [ ] Missing member variable doc comment
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [ ] Missing member variable doc comment
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [ ] Missing member variable doc comment
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [ ] Missing member variable doc comment
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [x] Missing function doc comment
20 | ERROR | [x] Expected 1 blank line before function; 2 found
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Missing function doc comment
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
36 | ERROR | [x] Missing function doc comment
37 | ERROR | [x] Opening brace should be on the same line as the declaration
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
39 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
49 | ERROR | [x] Expected 1 blank line after function; 0 found
50 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 31 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------FILE: web/modules/contrib/drupal-cache/src/MomentoCacheBackend.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 300 ERRORS AND 1 WARNING AFFECTING 251 LINES
-----------------------------------------------------------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Component\Assertion\Inspector.
12 | ERROR | [x] Missing class doc comment
13 | ERROR | [x] Opening brace should be on the same line as the declaration
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [ ] Missing member variable doc comment
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [ ] Missing member variable doc comment
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [ ] Missing member variable doc comment
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [ ] Missing member variable doc comment
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [ ] Missing member variable doc comment
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [ ] Missing member variable doc comment
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [ ] Class property $MAX_TTL should use lowerCamel naming without underscores
23 | ERROR | [ ] Missing member variable doc comment
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [ ] Missing member variable doc comment
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [ ] Missing member variable doc comment
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
27 | ERROR | [x] Missing function doc comment
32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
45 | ERROR | [x] Missing function doc comment
46 | ERROR | [x] Opening brace should be on the same line as the declaration
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Missing function doc comment
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Missing function doc comment
57 | ERROR | [x] Opening brace should be on the same line as the declaration
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
63 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
64 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
66 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
67 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
68 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
69 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
69 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the
| | allowed_classes option.
71 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
72 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24
73 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
75 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
76 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24
77 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
78 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
78 | ERROR | [x] Expected newline after closing brace
79 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
81 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
83 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
84 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [x] Missing function doc comment
92 | ERROR | [x] Opening brace should be on the same line as the declaration
93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
96 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
100 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
101 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
101 | ERROR | [x] Expected newline after closing brace
102 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
108 | ERROR | [x] Missing function doc comment
109 | ERROR | [x] Opening brace should be on the same line as the declaration
110 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
113 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
119 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
120 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
130 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
131 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
132 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
134 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
136 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
137 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
138 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
141 | ERROR | [x] Missing function doc comment
142 | ERROR | [x] Opening brace should be on the same line as the declaration
143 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
144 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
145 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
146 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
148 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
150 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
150 | ERROR | [x] Expected newline after closing brace
151 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
152 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
153 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
155 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
155 | ERROR | [x] Missing function doc comment
156 | ERROR | [x] Opening brace should be on the same line as the declaration
157 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
158 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
159 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
160 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
161 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
162 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
164 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
164 | ERROR | [x] Missing function doc comment
165 | ERROR | [x] Opening brace should be on the same line as the declaration
166 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
167 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
168 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
171 | ERROR | [x] Missing function doc comment
172 | ERROR | [x] Opening brace should be on the same line as the declaration
173 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
174 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
175 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
176 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
178 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
178 | ERROR | [x] Missing function doc comment
179 | ERROR | [x] Opening brace should be on the same line as the declaration
180 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
181 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
182 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
183 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
184 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
185 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
186 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
187 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
190 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
190 | ERROR | [x] Missing function doc comment
191 | ERROR | [x] Opening brace should be on the same line as the declaration
192 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
193 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
194 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
195 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
197 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
197 | ERROR | [x] Missing function doc comment
198 | ERROR | [x] Opening brace should be on the same line as the declaration
199 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
200 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
201 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
202 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
204 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
204 | ERROR | [x] Missing function doc comment
205 | ERROR | [x] Opening brace should be on the same line as the declaration
206 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
207 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
208 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
209 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
211 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
211 | ERROR | [x] Missing function doc comment
212 | ERROR | [x] Opening brace should be on the same line as the declaration
213 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
214 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
215 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
217 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
217 | ERROR | [x] Missing function doc comment
218 | ERROR | [x] Opening brace should be on the same line as the declaration
219 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
221 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
222 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
223 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
224 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
226 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
227 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
228 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
229 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
230 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
231 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
232 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
233 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
235 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
236 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
237 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
238 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
239 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
239 | ERROR | [x] Expected newline after closing brace
240 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
241 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
242 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
243 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
244 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
245 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
246 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
248 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
248 | ERROR | [x] Missing function doc comment
249 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
249 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
| | parentheses
250 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
251 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
252 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
252 | ERROR | [x] Expected newline after closing brace
253 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
254 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
255 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
256 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
257 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
258 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
259 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
261 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
262 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
263 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
264 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
265 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
266 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
268 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
268 | ERROR | [x] Missing function doc comment
268 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
269 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
270 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
271 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
273 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
274 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
275 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
277 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
278 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
279 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
280 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
280 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
281 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
282 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
284 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
284 | ERROR | [x] Missing function doc comment
285 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
285 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
286 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
288 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
288 | ERROR | [x] Missing function doc comment
288 | ERROR | [x] Incorrect spacing between argument "$message" and equals sign; expected 1 but found 0
288 | ERROR | [x] Incorrect spacing between default value and equals sign for argument "$message"; expected 1 but found 0
288 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
289 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
290 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
291 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
292 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
292 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
293 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
294 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
295 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
296 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
298 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
298 | ERROR | [x] Missing function doc comment
299 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
300 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
301 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
302 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
305 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 16
306 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
306 | ERROR | [x] Expected newline after closing brace
307 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
308 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
308 | ERROR | [x] Expected newline after closing brace
309 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
310 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
311 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
312 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
314 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
314 | ERROR | [x] Missing function doc comment
315 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
316 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
317 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
318 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
321 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
322 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
322 | ERROR | [x] Expected 1 blank line after function; 0 found
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 290 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------FILE: web/modules/contrib/drupal-cache/src/Client/MomentoClientFactory.php
----------------------------------------------------------------------------------------------------------
FOUND 39 ERRORS AFFECTING 29 LINES
----------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [ ] Missing member variable doc comment
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [ ] Missing member variable doc comment
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [ ] Missing member variable doc comment
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [ ] Missing member variable doc comment
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Missing function doc comment
18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
25 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Missing function doc comment
29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
41 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
42 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
42 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
43 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
46 | ERROR | [x] Expected 1 blank line after function; 0 found
47 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 35 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------FILE: web/modules/contrib/drupal-cache/tests/src/Kernel/MomentoCacheBackendTest.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 48 ERRORS AND 9 WARNINGS AFFECTING 42 LINES
-----------------------------------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [ ] Missing member variable doc comment
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Missing function doc comment
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
35 | ERROR | [x] Missing function doc comment
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
40 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
57 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
57 | WARNING | [x] 'TODO: I'd like to get this working consistently, but it's failing intermittently. However,' should
| | match the format '@todo Fix problem X here.'
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
58 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
58 | ERROR | [ ] Comment indentation error, expected only 1 spaces
59 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
60 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
62 | ERROR | [ ] Comment indentation error, expected only 2 spaces
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
63 | ERROR | [ ] Comment indentation error, expected only 4 spaces
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
68 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
69 | WARNING | [x] There must be no blank line following an inline comment
69 | WARNING | [ ] There must be no blank line following an inline comment
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
69 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
| | parentheses Addressed the mentioned errors and warnings by applying Drupal's Code Sniffing tool.
- Status changed to Needs review
9 months ago 11:22pm 12 March 2024 - Status changed to Postponed: needs info
9 months ago 10:30am 15 March 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Is the account used to create this application a shared account? If it is not, may you add your first name and last name on Personal information?
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Furthermore, the commits done in the project do not come from the account used to create this application. The username shown in the commit log is rishtigupta, and the email address is not the one associated to the account used to create this application.
Yes this is a shared account for our engineering team. We're looking to establish individual accounts for our engineering team members to facilitate their ability to push commits.
Additionally, I made an attempt to create my individual account on Drupal, but it was blocked. I have reached out to help@drupal.org for assistance.- Status changed to Needs review
9 months ago 7:01pm 15 March 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Shared accounts cannot be used to commit on drupal.org repositories ( Drupal.org Terms of Service / Accounts → ). They cannot be used for these applications to obtain a permission they should not use.
I understand. What should be the next steps for me to become a project maintainer within our Momento Account and gain the ability to contribute to the project?
- 🇮🇹Italy apaderno Brescia, 🇮🇹
A shared account can create projects, but not commit code. It can be the project owner and edit the project description, in the same way it can be used to edit an organization node.
If you want to commit code in drupal.org repositories, you need to create your own account, which is used just from you. You also need to create your project for the application.
- Status changed to Closed: won't fix
9 months ago 4:19pm 20 March 2024