- Issue created by @spokje
- Status changed to Needs review
9 months ago 8:15am 4 March 2024 - 🇦🇺Australia mstrelan
mstrelan → changed the visibility of the branch 3425304-10.3.x-resync-cspell-dictionary to hidden.
- 🇦🇺Australia mstrelan
mstrelan → changed the visibility of the branch 3425304-10.3.x-resync-cspell-dictionary to active.
- 🇦🇺Australia mstrelan
Don't mind me, accidentally hid a branch and promptly unhid it, now wondering if "unhid" is a word.
- 🇳🇱Netherlands spokje
Don't mind me, accidentally hid a branch and promptly unhid it, now wondering if "unhid" is a word.
Pretty sure it's "dehidrate", but we can't be sure until we have our spellcheck dictionary synced...
- Status changed to Needs work
9 months ago 3:50pm 4 March 2024 - 🇺🇸United States smustgrave
So on 11.x when I ran spellcheck:make-dict I didn't get the new words being added in the MR. Did get the removals.
- Status changed to Needs review
9 months ago 5:03pm 4 March 2024 - 🇳🇱Netherlands spokje
Well spotted @smustgrave!
Apparently there were a few local config files floating around, did these runs on a clean checkout.
- Status changed to RTBC
9 months ago 5:08pm 4 March 2024 - Status changed to Needs work
9 months ago 6:34pm 4 March 2024 - 🇳🇱Netherlands spokje
Hmmm, all MRs show as mergeable in GitLab and only contain changes in one file, the cspell dictionary, that isn't touched by any of the 4 commits since the creation of the MRs AFAICT.
So is there a git-reason for a rebase I'm missing, or is it because code got deleted in the 4 mentioned MRs which should have triggered changes in the dictionary?
- 🇬🇧United Kingdom catch
It was PEBKAC - I tried to apply the wrong MR diff to the wrong branch.
Committed/pushed to 11.x, 10.3.x, 10.2.x respectively, thanks!
- Status changed to Fixed
9 months ago 10:35pm 4 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.