Extensive Drupal 11 compatibility fixes, including new test coverage

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.19.2, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. mglaman/phpstan-drupal: 1.2.7
2. palantirnet/drupal-rector: 0.19.2

The automated fixes are all in compatibility code, so they don't need fixing. We should improve the tool instructions around them. The @noRector was clearly not enough :) I have a hard time to find docs as to how to correctly use that though. It would be good to improve that so that automated tooling does not complain.

@rishabjasrotia: we should also update the .gitlabci.yml file to test with Drupal 11 to make sure it actually works. That would at least involve updating that file itself but also a bunch of work on the tests probably, since the tests will start to fail given the lack of Drupal 12 compatible projects in the test set, so that will also need updating and also some test conditions.

Hello @gábor-hojtsy,
I manage to update the pipeline to include Drupal 11 for composer stage.
While we still need to see about D11 test cases.

Gábor Hojtsy → changed the visibility of the branch 3425263-upgrade-status-drupal-11 to hidden.

Gábor Hojtsy → changed the visibility of the branch 4.x to hidden.

@rishabjasrotia: thanks! the project-update-bot-only branch intentionally has that name. Please do not commit to that as it would cause problems for project update bot in the future. Please revert your commits on that branch. I integrated your changes on the other active branch (and removed the 4.x branch you accidentally started using as well).

I submitted this PR to DrupalPod to make it possible for anyone to try out this MR in Drupal 11 :) https://github.com/shaal/DrupalPod/pull/144

To try with that PR, one would need to use https://gitpod.io/new/#DP_PROJECT_NAME=upgrade_status,DP_ISSUE_FORK=upgr... (note my fork at the end).

When running Upgrade Status on Drupal 11 in that setup, I noticed the fails are related to what seems to be things outside Upgrade Status(?)

gitpod /workspace/DrupalPod (codespace-legendary-acorn-4gppv6gxv3qqj6) $ ddev phpunit --filter UpgradeStatusAccessTest
PHPUnit 9.6.17 by Sebastian Bergmann and contributors.

Testing 
E.                                                                  2 / 2 (100%)

Time: 00:05.803, Memory: 142.00 MB

There was 1 error:

1) Drupal\Tests\upgrade_status\Functional\UpgradeStatusAccessTest::testDeprecationDashboardAccessUnprivileged
Exception: Deprecated function: Return type of Drupal\Component\Annotation\Doctrine\StaticReflectionClass::getStaticProperties(): ?array should either be compatible with ReflectionClass::getStaticProperties(): array, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Drupal\Core\Render\ElementInfoManager->Drupal\Core\Render\{closure}()() (Line: 131)

/var/www/html/web/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:55
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:209
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:158
/var/www/html/vendor/guzzlehttp/promises/src/TaskQueue.php:52
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:251
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:227
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:272
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:229
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:69
/var/www/html/vendor/guzzlehttp/guzzle/src/Client.php:189
/var/www/html/web/core/tests/Drupal/Tests/DrupalTestBrowser.php:139
/var/www/html/vendor/symfony/browser-kit/AbstractBrowser.php:385
/var/www/html/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:122
/var/www/html/vendor/behat/mink/src/Session.php:175
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:284
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:254
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:373
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

ERRORS!
Tests: 2, Assertions: 9, Errors: 1.

HTML output was generated
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusAccessTest-1-46676110.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusAccessTest-2-46676110.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusAccessTest-3-46676110.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusAccessTest-4-46676110.html

Unsilenced deprecation notices (2)

Remaining self deprecation notices (32)

Remaining direct deprecation notices (10)

Remaining indirect deprecation notices (2)

Other deprecation notices (13)
Failed to run phpunit --filter UpgradeStatusAccessTest: exit status 2

-----------

This one has a real fail at least.

gitpod /workspace/DrupalPod (codespace-legendary-acorn-4gppv6gxv3qqj6) $ ddev phpunit --filter UpgradeStatusUiTest
PHPUnit 9.6.17 by Sebastian Bergmann and contributors.

Testing 
.F.                                                                 3 / 3 (100%)

Time: 00:57.438, Memory: 142.00 MB

There was 1 failure:

1) Drupal\Tests\upgrade_status\Functional\UpgradeStatusUiTest::testUiAfterScan
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'No problems found'
+'1 problem'

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:79
/var/www/html/repos/upgrade_status/tests/src/Functional/UpgradeStatusUiTest.php:56
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

FAILURES!
Tests: 3, Assertions: 44, Failures: 1.

HTML output was generated
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-1-80846985.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-2-80846985.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-3-80846985.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-4-80846985.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-5-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-6-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-7-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-8-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-9-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-10-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-11-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-12-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-13-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-14-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-15-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-16-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-17-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-18-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-19-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-20-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-21-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-22-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-23-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-24-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-25-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-26-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-27-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-28-72289450.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-29-72289450.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-30-72289450.html

Unsilenced deprecation notices (3)

Remaining self deprecation notices (68)

Remaining direct deprecation notices (10)

Remaining indirect deprecation notices (3)

Other deprecation notices (13)
Failed to run phpunit --filter UpgradeStatusUiTest: exit status 1

This later one is due to version specific logic. I'll review the version specific logic as we need some kind of strategy for this, especially if we want to support this on Drupal 9, 10 and 11 all at once and have tests that span all across.

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.10
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.1
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.2

Update title for correctness :)

Automatically closed - issue fixed for 2 weeks with no activity.