Automated Drupal 11 compatibility fixes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.19.2, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. mglaman/phpstan-drupal: 1.2.7
2. palantirnet/drupal-rector: 0.19.2

The last submitted patch, 2: jsonapi_extras.8.x-3.24.rector.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → changed the visibility of the branch project-update-bot-only to hidden.

The tests don't pass in the MR so "Needs work".

bbrala → changed the visibility of the branch project-update-bot-only to active.

Ran command ./vendor/bin/drush upgrade_status:analyze jsonapi_extras I can see below status which can be ignored.

================================================================================
JSON:API Extras, --
Scanned on Fri, 05/31/2024 - 12:30

FILE:
modules/contrib/jsonapi_extras/modules/jsonapi_defaults/src/Controller/EntityRes
ource.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 29   Class Drupal\jsonapi_defaults\Controller\EntityResource     
                    extends @internal class                                     
                    Drupal\jsonapi\Controller\EntityResource.                   
--------------------------------------------------------------------------------

FILE:
modules/contrib/jsonapi_extras/src-impostor-normalizers/ResourceIdentifierNormal
izerImpostor.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 10   Class                                                       
                    Drupal\jsonapi\Normalizer\ImpostorFrom\jsonapi_extras\Resour
                    ceIdentifierNormalizerImpostor extends @internal class      
                    Drupal\jsonapi_extras\Normalizer\ResourceIdentifierNormalize
                    r.                                                          
--------------------------------------------------------------------------------

FILE:
modules/contrib/jsonapi_extras/src-impostor-normalizers/ResourceObjectNormalizer
Impostor.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 10   Class                                                       
                    Drupal\jsonapi\Normalizer\ImpostorFrom\jsonapi_extras\Resour
                    ceObjectNormalizerImpostor extends @internal class          
                    Drupal\jsonapi_extras\Normalizer\ResourceObjectNormalizer.  
--------------------------------------------------------------------------------

FILE:
modules/contrib/jsonapi_extras/src/ResourceType/ConfigurableResourceType.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 15   Class                                                       
                    Drupal\jsonapi_extras\ResourceType\ConfigurableResourceType 
                    extends @internal class                                     
                    Drupal\jsonapi\ResourceType\ResourceType.                   
--------------------------------------------------------------------------------

FILE:
modules/contrib/jsonapi_extras/src/ResourceType/ConfigurableResourceTypeReposito
ry.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 15   Class                                                       
                    Drupal\jsonapi_extras\ResourceType\ConfigurableResourceTypeR
                    epository extends @internal class                           
                    Drupal\jsonapi\ResourceType\ResourceTypeRepository.         
--------------------------------------------------------------------------------

Since all tests are passing hence requesting review.

I did a basic code review. Please correct me if I'm wrong, but I think the changes need to be made on the 3425240-automated-drupal-11-fix branch (or a new branch), but not the project-update-bot-only because that branch is, as the name suggests, only for project-update-bot.

Sorry, I just this branch to test some changes to gitlab templates. So there is some silly changes.

@chandu running the scripts is not really testing. ;)

Closing out this issue to get a fresh one, there has been some testing here. Will go through issues later to consolidate the actual help given.

Hello @bbrala,

Project bot has opened a new → ticket for Drupal 11 compatibility as may be because you have closed this ticket without merging any code.

If I understand correctly, you are expecting only Drupal 11 changes in this ticket and there are many other changes which might make it difficult to release D11 stable version, hence you closed the issue and stated "closing out this issue to get a fresh one". Is it likely that the changes to D11 specific on the new → ticket will facilitate the release of D11?

Yeah this ticket was getting messy, also because i used this as a testing ground for some things. I will work on d11 soonish, seems it wont be that hard.