- Issue created by @ressa
- Status changed to Needs review
about 1 year ago 10:50pm 2 March 2024 - Status changed to RTBC
9 months ago 9:09am 17 June 2024 - 🇹🇷Turkey orkut murat yılmaz Istanbul
I've tested it locally. @ressa, thanks for the D11 compatibility:)
- 🇮🇹Italy itamair
ok ... thanks @here!
I am going to sit for final green flag for merging this Geofield Drupal 11 compatibility Issue:
https://www.drupal.org/project/geofield/issues/3430742 📌 Automated Drupal 11 compatibility fixes for geofield RTBC
and then will proceed with this one also ... :-) - Status changed to Fixed
9 months ago 8:16am 20 June 2024 - 🇮🇹Italy itamair
Thanks. This was merged and is going to be part of the next Leaflet 10.2.18 incoming release.
- 🇩🇰Denmark ressa Copenhagen
Thanks @itamair, and @Orkut Murat Yılmaz for reviewing!
To prevent abuse, for example by creating a branch or uploading a file only to get credit (I searched, but can't find the issue where it was decided), credits are no longer added automatically. So the maintainer needs to remember do it ...
A maintainer has not commented and given credit yet.
- 🇩🇰Denmark ressa Copenhagen
I found the issue. In the Gitlab issue system, where Drupal issues are moving soon, crediting will be part of the process of closing an issue, from #3395901-28: Use Gitlab CI in Simplenews → :
We could create an automated message, but that will actually happen when we are in "GitLab issues" as it is already implemented via a webhook when closing the issue.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇩🇰Denmark ressa Copenhagen
What is strange is that it says (#7) "Issue #3425163 by ressa, Orkut Murat Yılmaz: Support Drupal 11 in..." but under "Credit & committing", it says this:
A maintainer has not commented and given credit yet.
Though it's not listed under my credited issues for Leaflet:
- Add support for GDPR-friendly openstreetmap.de updated 28 Jun 2024 at 15:24 CEST
- Remove Wikimedia Maps updated 12 Jun 2024 at 10:19 CEST
- Document how custom maps and layer switcher works updated 11 Jun 2024 at 21:29 CEST
- Update Stamen map tiles to use Stadia hosting updated 11 Jun 2024 at 21:24 CEST
- Add opentopomap.org to Leaflet More Maps updated 29 May 2024 at 10:16 CEST
- [Meta] Release version 2.2 updated 29 May 2024 at 10:15 CEST
- Current Esri Ocean Map is broken updated 18 Feb 2024 at 22:09 CET
- Add support for Mapy.cz updated 12 Jan 2024 at 17:24 CET
- Show names in layer switcher updated 5 Jan 2024 at 14:49 CET
- 🇩🇰Denmark ressa Copenhagen
I just checked, and found two issue where I could have gotten credit as well ...