- Issue created by @puffoon
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPractice
on the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
- If you have not done it yet, you should run
- 🇺🇸United States puffoon
phpcs is run and all issues are fixed.
The release is at
https://www.drupal.org/project/cp2clip/releases/1.0.1-rc1 →composer require 'drupal/cp2clip:^1.0@RC'
- Status changed to RTBC
9 months ago 6:09am 15 March 2024 - 🇮🇳India rushiraval
I have reviewed code. But I think there is not enough php code to review.
Senior reviewer may review code with this point.
- Status changed to Needs work
9 months ago 9:00am 15 March 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Since there is a module with the same purpose, the project page should give a more detailed description of the differences between the modules.
Also, the module used for this application does not contain enough PHP to understand your skills in writing secure code that correctly uses the Drupal API and follows the Drupal coding standards. Actually, not even the JavaScript code correctly uses the Drupal JavaScript API.
Is there another project hosted on drupal.org that we can instead review?
- 🇮🇹Italy apaderno Brescia, 🇮🇹
As a side note, checking the project files should have been done right after posting the first comment on this issue. puffoon should have waited 15 days to be said the project does not contain enough PHP code.
The person posting the welcome comment should also check that and how many people committed code in the project used for an application. - 🇮🇳India vishal.kadam Mumbai
I am changing priority as per Issue priorities → .
- 🇮🇳India vishal.kadam Mumbai
This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.