Move statistics_node_translation_counter to Statistics module

Created on 27 February 2024, 10 months ago
Updated 13 March 2024, 9 months ago

Problem/Motivation

statistics_node_translation_counter migration is in the content translation module.

Steps to reproduce

Proposed resolution

move it to statistics

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Fixed

Version

10.3 ✨

Component
StatisticsΒ  β†’

Last updated 4 days ago

No maintainer
Created by

πŸ‡³πŸ‡ΏNew Zealand quietone

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @quietone
  • Merge request !6785move migration β†’ (Closed) created by quietone
  • Pipeline finished with Success
    10 months ago
    #104854
  • Status changed to Needs review 10 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone

    Ready for review

  • Status changed to RTBC 10 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Change makes sense and needed to deprecate statistics probably.

    • catch β†’ committed 70889f50 on 10.3.x
      Issue #3424009 by quietone: Move statistics_node_translation_counter to...
    • catch β†’ committed 686803df on 11.x
      Issue #3424009 by quietone: Move statistics_node_translation_counter to...
  • Status changed to Fixed 10 months ago
  • πŸ‡¬πŸ‡§United Kingdom catch

    Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

  • πŸ‡³πŸ‡ΏNew Zealand quietone

    I realized this morning that moving a multi-lingual migration out of content_translation might cause problems because they were placed in content_translation so they were not discovered.

    I did some local testing and confirmed that the statistics_node_translation_counter is now discovered when content_language is not installed. Ideally, that should not happen but it is working as designed.

    This means that this translation related migration will always run when using the 'one click' upgrade or similar drush command. Fortunately, that does not cause errors because this migration is to support the Classic node migrations. The 'one click' upgrade uses the Node Complete migrations where d6_node_translation and d7_node_translation are not used. When statistics_node_translation_counter runs every row will be skipped because migration_lookup will return a NULL.

      nid:
        -
          plugin: migration_lookup
          migration:
            - d6_node_translation
            - d7_node_translation
          source: nid
        -
          plugin: skip_on_empty
          method: row
        -
          plugin: extract
          index:
            - 0
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024