Enable testing with GitLab CI

I set up GitLab CI. You can see the results on the MR: https://git.drupalcode.org/project/conditional_fields/-/merge_requests/41.

I fixed most of the errors and warnings reported by phpcs.

I added a baseline for phpstan, so that we can try to avoid new errors and eventually fix the existing ones. I used the one generated as an artifact from the GitLab CI run. But that does not seem to be working, so I am setting the issue status to NW.

I fixed the one problem reported by stylelint.

I would rather let someone more familiar with JS take a look at the eslint results.

I am still doing something wrong with phpstan.

@D-XPERT:

Thanks for looking at the eslint errors. I left a few comments on the MR. If you have a chance, please respond to them. I am setting the issue status back to NW for that.

Your commit messages were brief. Could you say a little more? It looks as though the first commit might have been automated fixes, and the second commit was manual. Is that right?

Meanwhile, I have ignored the remaining phpcs error, fixed my broken phpstan configuration, and updated a test to match the changes in the code. I think this issue is almost done!

@benjifisher, thanks for the review. I will work on the suggestions.

Awesome work in here. 1+! Thanks for working on this important issue! Will follow and will be available for any question.

I felt the JS changes are too risky in this "enable gitlab ci" issue. We can resurrect them in a follow-up clean-up task. JS style linting fix stuffs do not break the build in gitlab, they are just thrown as warnings. Better to solve in a dedicated issue.

Thanks for all your contributions here. It made it really easy to commit things at the end.

Opened 📌 Fix eslint errors Needs review as a hopefully much easier to review follow-up.

Thanks for all your contributions here.

I would like to add my voice to that. Very much appreciated contribution. Thanks a million. And many many thanks to heddn for tracking and merging it so fast. And yes, good idea to split the eslint warnings to move on.

Automatically closed - issue fixed for 2 weeks with no activity.