Add Paragraphs buttons have a misleading look

Created on 23 February 2024, 4 months ago
Updated 15 April 2024, 2 months ago

Problem/Motivation

While I am very clear that the MOVE UP and MOVE DOWN icons are very clear, I have noticed with members of the Editor team miss the PLUS sign on the ADD above and ADD below and instead, interpret those tow icons and MOVE up and down...

Basically, I think the PLUS signs need to be a little more obvious, maybe something like this...

Feature request
Status

Fixed

Version

1.5

Component

Code

Created by

🇬🇧United Kingdom SirClickALot Somerset

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @SirClickALot
  • 🇩🇪Germany a.dmitriiev

    Hi, there is another issue here https://www.drupal.org/project/frontend_editing/issues/3423781 📌 Update Frontend Editing UI Needs review that changes a bit the look of the buttons, probably it should fix this issue. If yes, feel free to close this issue in favour of that one.

    Thanks for reporting this.

  • Status changed to Fixed 4 months ago
  • 🇩🇪Germany a.dmitriiev

    Try new 1.6.0 version

  • 🇬🇧United Kingdom SirClickALot Somerset

    Great work, a super improvement!

    Just one thing from me and that is that the extra vertical borders when Paragraphs are inside others causing some unsightly 'jiggling'...

    Suggest only adding vertical borders to the outermost element?

  • Status changed to Active 4 months ago
  • 🇩🇪Germany a.dmitriiev

    Good suggestion, this will be worked on.

  • 🇩🇪Germany breidert

    @sirclickalot - have you tried enabling hover mode at /admin/config/frontend-editing/ui-settings? This makes it a bit nicer.

    But if you have a good suggestion for a visual improvement, please write it :-)

  • 🇬🇧United Kingdom SirClickALot Somerset

    @breidert

    Thanks for that suggestion, I tried it and if I'm honest, I think it's worse still.

    The reason is that now, in addition to the HORIZONTAL pad, it now also pushed the content DOWN using an animation ;-(

    My overall take on all of this is that what is best for editors is zero 'movement' of the underlaying content - all they should see is obvious but subtle highlighting floating over the top of the editing target(s).

    Other visual improvements

    Textual 'Add before' and 'Add after' links

    I also note that you can just about see a textual 'Add before' link underneath the .common-actions-container...

    If I kill off the .common-actions-container then it is easier to see...

    While I of course understand that it needs to be present for accessibility, I don't think it should be visible to the eye.

    Border widths and colours

    I suggest that the widths of the borders when hovering should be kept to a minimum in width and that they were actually better when they were more subtlety-coloured.

    For me this is all about leaving the content exactly as-is (i.e. no movement) and then only ever making subtle 'suggestions' as to what the content editor might want to 'move' or 'edit'.

    When the content-editor is hovering over the content, they already the strong intention to edit, they just to be able to 'see' a confirmation the available options not have then thrust into their face ;-)

    A crude mock-up...

    If it helps, this is a content-focussed philosophy that we practice on all our educational pages because we want to avoid our learners from being distracted from the main content we are trying to get them to consume.

    Thus, we provide all the little EXTRAS but we do so subtlety; this seems to work very well as they seem to enjoy the experience better than ones where they are offered too many options too overtly...

  • 🇬🇧United Kingdom SirClickALot Somerset

    I just wanted to add another couple of point sin relation to cosmetics.

    Vertical jiggle

    I have managed to remove the horizontal movement simply by overriding CSS but I am still getting the vertical 'jiggle' ...

    No option to colour + signs

    I have also been able to easily re-colour the bounding boxes back to the colours as in v1.5x but the + signs are proving challenge because they are SVGs....

  • 🇬🇧United Kingdom SirClickALot Somerset

    Finally, I wondered what the thinking was behind with the adjusted letter-spacing...

    .action-title {
    ...
      letter-spacing: 0.2em;
    ...
    }

    I hope all this is useful feedback - you did ask!

    Overall, I think I would be happier as a site-builder / theme to see as little imposed colour and styling as possible.
    That said I appreciate it's a tricky business getting the balance right.

    The new hover / plus signs approach of v1.6x is still a good move forward!

  • 🇩🇪Germany breidert

    @SirClickalot - your feedback is highly appreciated, we also reviewed internally and arrived at similar conclusions.

    We plan to release a new version in next week with the above improved.

    Question: Do you think a toggle for editing is useful? Then you could turn off all frontend_editing effects and interaction elements if you want to review or simply consume content.

    I am thinking about something like this:

  • 🇬🇧United Kingdom SirClickALot Somerset

    Hi,

    Yes, I agree, a 'global' ON/OFF would be very nice because often, content-editors might also be 'normal' site users.

    My gut feeling is to go with toggles that exactly match the Gin theme since it is - in my opinion anyway - THE theme to use for backend editing and admin pages...

    and

    Also, as I mentioned in another issue, the ability to configure entire regions and/or blocks where which we never want to see any FEE prompts.

  • Status changed to Fixed 3 months ago
  • 🇩🇪Germany a.dmitriiev

    I will close this issue, because it was about the add buttons, that were changed already. The other findings are now there own issues https://www.drupal.org/project/frontend_editing/issues/3436377 📌 Improve Frontend Editing UI/UX including nested elements Fixed and https://www.drupal.org/project/frontend_editing/issues/3436501 📌 Implement a toggle that shows/hides the Frontend Editing UI Active

  • 🇬🇧United Kingdom SirClickALot Somerset

    I have noticed that latest release (1.61) we are still seeing plenty of 'jiggling' with embedded Paragraphs...

  • 🇩🇪Germany a.dmitriiev

    @SirClickalot, please report this in another issue. This issue was about changing the icons of add buttons. Here is an issue with some improvements https://www.drupal.org/project/frontend_editing/issues/3436377 📌 Improve Frontend Editing UI/UX including nested elements Fixed , so probably your comment should land there instead.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024