Fix the issues reported by phpcs

Hi bhaveshdas,

I reviewed MR!1, applied against Ckeditor5 entity browser 1.0.x-dev with Drupal core version 10.1.7, and confirmed it fixes the issue reported by phpcs.

Command used: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,yml,twig ckeditor5_entity_browser

jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,yml,twig ckeditor5_entity_browser

FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/ckeditor5_entity_browser/src/Plugin/CKEditor5Plugin/CkeditorEntityBrowser.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
 130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------------

Time: 121ms; Memory: 10MB

jetherparadero@PrometSources-MacBook-Pro contrib % cd ckeditor5_entity_browser
jetherparadero@PrometSources-MacBook-Pro ckeditor5_entity_browser % curl https://git.drupalcode.org/project/ckeditor5_entity_browser/-/merge_requests/1.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   699    0   699    0     0   1661      0 --:--:-- --:--:-- --:--:--  1688
Checking patch src/Plugin/CKEditor5Plugin/CkeditorEntityBrowser.php...
Applied patch src/Plugin/CKEditor5Plugin/CkeditorEntityBrowser.php cleanly.
jetherparadero@PrometSources-MacBook-Pro ckeditor5_entity_browser % cd ..
jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,yml,twig ckeditor5_entity_browser
jetherparadero@PrometSources-MacBook-Pro contrib %

Thank you.

As per #4 i resolve all errors

i used below command for checking
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml web/modules/contrib/ckeditor5_entity_browser/

could you please review it.

Thankyou!!

Hi,
Applied the patch #6 and found no errors and warning.
Applied MR!1 and found no errors and warnings.
Thank you!!

@bhaveshdas merged the MR for the PHP fix.

Note however that JS support in phpcs has been removed for a while now (for that eslinters are recommeded) and cause lots of false positives. Like the issues in the template literal in the patch at #6.

Automatically closed - issue fixed for 2 weeks with no activity.