- Issue created by @mohit_aghera
- First commit to issue fork.
- 🇮🇳India mohit_aghera Rajkot
@dineshkumarbollu
This issue is for Novice contributors.
Based on your profile it seems you've enough experience.Please don't pick Novice issues, keep it for *real novice* users.
Also, there are phpcs failures. Can you please address those.
- 🇮🇳India dineshkumarbollu
Sure @mohit_aghera, i am started contributing to core, I won't take novice issues future, Noted.
- Status changed to Needs review
9 months ago 11:42am 22 February 2024 - 🇮🇳India mohit_aghera Rajkot
Changes looks good. Since we are removing docblock text, I don't anticipate regression.
- Status changed to RTBC
9 months ago 2:44pm 22 February 2024 - 🇺🇸United States smustgrave
@dineshkumarbollu this was tagged for novice for new drupal users. Ticket wasn't a day old and looking at your post history you have over 27 pages of posts. Please avoid novice tagged issues for our newer users.
What's done is done though.
- Status changed to Fixed
9 months ago 5:25pm 23 February 2024 - 🇬🇧United Kingdom catch
I had to double check this wasn't some kind of weird bc layer for annotation, but there is a non-weird bc layer in
Drupal\Core\Annotation\Action
so I think instead this is just copypasta from when the new attribute was added.Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.