- Issue created by @longwave
alexandre.baron@symetris.com β made their first commit to this issueβs fork.
- Assigned to alexandre baron
- Merge request !67253422708: Remove escapeCdataElement in serialize function. β (Open) created by Unnamed author
- Status changed to Needs review
10 months ago 2:43pm 21 February 2024 - Status changed to Needs work
10 months ago 3:08pm 21 February 2024 - πΊπΈUnited States smustgrave
Seems like a feature that will need test coverage. Fact nothing broke shows we don't have it.
Deprecate Html::escapeCdataElement().
Still needed.
- π¬π§United Kingdom longwave UK
As far as I can tell this is dead code since π Upgrade filter system to HTML5 Fixed , previously we ended up with scripts/styles wrapped in CDATA but this is no longer required in HTML5 and tests were updated over there to remove CDATA, so I think no new tests are needed here either (except maybe a deprecation test, I guess).
- πΊπΈUnited States smustgrave
Will let you make the call on deprecation tests. Deprecation for sure. But tests for something that didn't work may be overkill then.
- π¬π§United Kingdom longwave UK
We need to add a deprecation notice to Html::escapeCdataElement() and write a test that covers it. We also need a change record that documents the deprecation.
See https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... β for how to deprecate the method, and you can find existing deprecation tests in core that you can copy and alter for this new deprecation.