- Issue created by @mstrelan
- Merge request !6690Make use of is_iterable and is_countable functions β (Open) created by mstrelan
- Status changed to Needs review
3 months ago 5:46am 20 February 2024 - Status changed to RTBC
3 months ago 6:08pm 20 February 2024 - πΊπΈUnited States smustgrave
Doing searches for $value instanceof \Traversable and instanceof \Countable; and checking if they're also checking is_array, believe all have been addressed.
Left a comment but I would +1 for deprecating that one function since it does 1 thing now.
- Status changed to Needs work
3 months ago 9:48pm 20 February 2024 - Status changed to Needs review
3 months ago 11:33pm 20 February 2024 - π¦πΊAustralia mstrelan
Deprecated
Inspector::assertTraversable
and added a change record. Applied both suggestions. - Status changed to Needs work
3 months ago 3:04pm 21 February 2024 - πΊπΈUnited States smustgrave
Left some comments on MR about the CR link.
But checked that the replacements were done. Probably good to self RTBC @mstrelan after the link updates.
- Status changed to RTBC
3 months ago 10:59pm 21 February 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed c506000f20 to 11.x and 8b6fd70a73 to 10.3.x. Thanks!
-
alexpott β
committed 8b6fd70a on 10.3.x
Issue #3422543 by mstrelan, smustgrave, longwave: Make use of...
-
alexpott β
committed 8b6fd70a on 10.3.x
- Status changed to Fixed
3 months ago 2:04am 29 February 2024 -
alexpott β
committed c506000f on 11.x
Issue #3422543 by mstrelan, smustgrave, longwave: Make use of...
-
alexpott β
committed c506000f on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.