- Issue created by @benjifisher
- Status changed to Needs review
10 months ago 7:27am 13 March 2024 - ๐ฎ๐ณIndia sarwan_verma
Hi @benjifisher,
I have fixed this issue "Normalizers/Denormalizers should implement ::getSupportedTypes() instead of ::hasCacheableSupportsMethod()" and also attached patch,
please review and verify. - Status changed to Needs work
10 months ago 2:56pm 13 March 2024 - ๐บ๐ธUnited States nicxvan
Thank you Sarwan, I appreciate your contribution can you please move this patch to a merge request?
That makes it easier to review, test and merge in the future.
- ๐ฎ๐ณIndia abhishek_virasat
abhishek_gupta1 โ made their first commit to this issueโs fork.
- ๐บ๐ธUnited States nicxvan
Thank you for moving this to an MR, I think your change is expanding the scope quite a bit of this MR.
Is there a reason you are mixing in a bunch of other changes?
- Status changed to Fixed
6 months ago 2:55am 31 July 2024 - ๐บ๐ธUnited States nicxvan
This was fixed in ๐ Normalizers/Denormalizers should implement ::getSupportedTypes() instead of ::hasCacheableSupportsMethod() Needs work
- ๐บ๐ธUnited States benjifisher Boston area
@nicxvan:
The link in Comment #7 points to this issue.
I think the problem was fixed in Commit 69d089e, which does not refer to any issue.
- ๐บ๐ธUnited States nicxvan
Yes thank you, that's what I meant to link to.
Automatically closed - issue fixed for 2 weeks with no activity.