[1.0.x] VK Entity identifier

Thank you for applying! The project link is not for the VK Entity identifier module.

Thank you for your vigilance @apaderno. The link has been updated.

Fix phpcs issue.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_identif
ier/

FILE: /home/vishalkadam/DRUPAL-REVIEW/entity_identifier/vk_entity_identifier.module                                                    
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE                                                                                                         
--------------------------------------------------------------------------------
 101 | ERROR | The array declaration extends to column 109 (the limit is 80). The array content should be split up over multiple lines 
--------------------------------------------------------------------------------

Hi Vishal,

The PHPCS issue has been fixed.

Best,

Modification of the issue priority according to the standard →

According to the standard, I am allowing myself to set the ticket status to 'critical,' as it has been awaiting feedback for two months

FILE: vk_entity_identifier.module

/**
 * @file
 * Contains the vk_entity_identifier module hooks.
 */

The description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

Hello Vishal,

Thank you for your feedback, but I must admit that I do not understand.
The purpose of these reviews is to validate the development skills of a developer and to test the security of a module so that it can be declared compliant with Drupal's Security Team.
Here, you are giving me feedback on the wording of a sentence, without addressing the substance of a code review. Could you perform a substantive check?
Furthermore, I do not understand your point. Which part of the documentation stipulates that we need to formulate what you are mentioning? According to the core code of the latest stable version of Drupal 10, all core modules would not meet your request.

I thank you in advance for your feedback and clarifications.

The relevant documentation is @file: Documenting files → , which does not say the description for a module must be Hook implementations for the Entity identifier module. My usual comment about that description is that the usual description is that, which means the description change should be considered, and I usually report it when there are more changes to do.

As for the purposes of these applications, we verify what the applicant understands about writing Drupal code that correctly uses the Drupal API, follows the Drupal coding standards, and does not contain any possible security issue. We do not focus only on security issues, which would be instead a task for the Security Team.

• The following points are just a start and don't necessarily encompass all of the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that doesn't follow the coding standards, contains possible security issue, or does not correctly use the Drupal API; the single points are not ordered, not even by importance

composer.json

"license": "GPL-3.0-or-later",

Projects hosted on drupal.org are licensed under GPLv2+, the same license used from Drupal core. If you are licensing a project under a different license, it cannot he hosted on drupal.org. More details are given in Drupal Git Contributor Agreement & Repository Usage Policy → .

All code that is a derivative work of Drupal (typically PHP code, including but not limited to: core patches, modules, themes, etc) committed to Drupal.org's git repository is licensed as GPL version 2.0 and later (official short identifier: “GPL-2.0-or-later”). This means that the code is licensed under GPLv2, and there exists an option that allows downstream recipients to re-license the code to be under a later version of GPL.

For code licensed under GPLv3, see I want to release my work under GPL version 3 or under GPL version 2-only. Can I do so and host it on Drupal.org? →

No. You can release your work under any GPL version 2 or later compatible license. However, you may only check it into Drupal's Git repositories if you are releasing it under the same license as Drupal itself, that is GPL version 2 or later, allowing users to choose between the terms of the GPL version 2 or the terms in any new versions as updated by the FSF. If you are unable or unwilling to do so, do not check it into a Drupal Git repository.

Hello @apaderno,

Thank you for your feedback.
I have updated the code to reflect the correct license. Are there any other issues you've noticed that need addressing?

Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !

Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank also the dedicated reviewers as well.

Thank you for your time and advice.
Have a great day,
Julien

We do not close fixed issues, since they are automatically closed after 14 days.

Automatically closed - issue fixed for 2 weeks with no activity.