Thank you for your time and advice.
Have a great day,
Julien
Hello @apaderno,
Thank you for your feedback.
I have updated the code to reflect the correct license. Are there any other issues you've noticed that need addressing?
Hello Vishal,
Thank you for your feedback, but I must admit that I do not understand.
The purpose of these reviews is to validate the development skills of a developer and to test the security of a module so that it can be declared compliant with Drupal's Security Team.
Here, you are giving me feedback on the wording of a sentence, without addressing the substance of a code review. Could you perform a substantive check?
Furthermore, I do not understand your point. Which part of the documentation stipulates that we need to formulate what you are mentioning? According to the core code of the latest stable version of Drupal 10, all core modules would not meet your request.
I thank you in advance for your feedback and clarifications.
According to the standard, I am allowing myself to set the ticket status to 'critical,' as it has been awaiting feedback for two months
Modification of the issue priority according to the standard →
Hi Vishal,
Thank you for your suggestion.
The module has been updated with a README.md (https://git.drupalcode.org/project/entity_identifier/-/blob/1.0.x/README...)
Have a good day.
Hi Vishal,
The PHPCS issue has been fixed.
Best,
Thank you for your vigilance @apaderno. The link has been updated.
jgrossio → created an issue.