- Issue created by @gorkagr
- Status changed to Needs review
10 months ago 4:35pm 18 February 2024 - Status changed to RTBC
10 months ago 11:09pm 18 February 2024 - πΊπΈUnited States smustgrave
Checked this with phpstorm and it's also flagging this function as an incorrect return.
Looking at the code $elements['#markup'] is being updated and $elements returned so clearly an array.
- Status changed to Needs work
10 months ago 2:32am 19 February 2024 - π¦πΊAustralia mstrelan
Not sure we can add the return type without a CR at the very least. I think the docs update is fine, but there are at least a handful of contrib modules extending the Renderer class that would break if the override
::ensureMarkupIsSafe
. - Status changed to Needs review
10 months ago 7:58am 19 February 2024 - π§πͺBelgium gorkagr
I have removed the return type, but as the function is protected, i think it was ok to leave it there (i did query the function within git and i did not find a match except for his function itself)
- Status changed to RTBC
10 months ago 8:29am 19 February 2024 - Status changed to Fixed
10 months ago 12:06am 29 February 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed e65cc2e481 to 11.x and 02428eb872 to 10.3.x and 983d2909eb to 10.2.x. Thanks!
Backported to 10.2.x as a docs fix.
-
alexpott β
committed 983d2909 on 10.2.x
Issue #3422222 by gorkagr, mstrelan, smustgrave: Wrong return type in...
-
alexpott β
committed 983d2909 on 10.2.x
-
alexpott β
committed 02428eb8 on 10.3.x
Issue #3422222 by gorkagr, mstrelan, smustgrave: Wrong return type in...
-
alexpott β
committed 02428eb8 on 10.3.x
-
alexpott β
committed e65cc2e4 on 11.x
Issue #3422222 by gorkagr, mstrelan, smustgrave: Wrong return type in...
-
alexpott β
committed e65cc2e4 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.