- Issue created by @larowlan
- First commit to issue fork.
- Status changed to Needs review
12 months ago 9:24am 15 February 2024 - Status changed to Needs work
12 months ago 9:43am 15 February 2024 - π¦πΊAustralia mstrelan
Added some suggestions mostly the same as on the Mail issue but didn't get through the whole MR.
- Status changed to Needs review
11 months ago 11:37am 29 February 2024 - Status changed to Needs work
11 months ago 12:21pm 29 February 2024 - π¦πΊAustralia mstrelan
Couple nits but also I don't think the last few params should be nullable.
- First commit to issue fork.
- π¦πΊAustralia mstrelan
FWIW I opened π Create enum for FilterInterface constants Needs work which is relevant, but not a blocker, for this issue.
- First commit to issue fork.
- Status changed to Needs review
11 months ago 12:43pm 7 March 2024 - Status changed to Needs work
11 months ago 4:15pm 7 March 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I really wanted to RTBC this, but there are a few incorrect default values here that would cause regressions after contrib adopts this.
This is 99% ready, nice job! π₯³
- Status changed to Needs review
11 months ago 4:38am 8 March 2024 - Status changed to RTBC
11 months ago 7:31am 8 March 2024 - Status changed to Fixed
11 months ago 11:04am 8 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 1d07b82287 to 11.x and 1e89b0ca64 to 10.3.x. Thanks!
-
alexpott β
committed 1e89b0ca on 10.3.x
Issue #3421012 by sorlov, quietone, sakthi_dev, mstrelan, Wim Leers:...
-
alexpott β
committed 1e89b0ca on 10.3.x
-
alexpott β
committed 1d07b822 on 11.x
Issue #3421012 by sorlov, quietone, sakthi_dev, mstrelan, Wim Leers:...
-
alexpott β
committed 1d07b822 on 11.x
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Thanks, that really paves the path for π Create enum for FilterInterface constants Needs work π
Automatically closed - issue fixed for 2 weeks with no activity.