- Issue created by @larowlan
- Assigned to mstrelan
- Status changed to Needs review
about 1 year ago 4:10am 16 February 2024 - Issue was unassigned.
- Status changed to RTBC
about 1 year ago 2:40pm 1 March 2024 - πΊπΈUnited States smustgrave
Sorry didn't mean to leave this hanging.
Based on your last comment seems "Additional annotation keys" isn't a problem I believe.
Searched for @FieldWidget and all 37 instances in core have been replaced.
From feedback on other tickets also searched for Field\Annotation\FieldWidget and that was replaced also.
- π¬π§United Kingdom alexpott πͺπΊπ
Committed d0e9611 and pushed to 11.x. Thanks!
Committed 890e58d and pushed to 10.3.x. Thanks!diff --git a/core/lib/Drupal/Core/Field/Attribute/FieldWidget.php b/core/lib/Drupal/Core/Field/Attribute/FieldWidget.php index f93433e7b2..9b98af3cd5 100644 --- a/core/lib/Drupal/Core/Field/Attribute/FieldWidget.php +++ b/core/lib/Drupal/Core/Field/Attribute/FieldWidget.php @@ -12,7 +12,7 @@ * * Widgets handle how fields are displayed in edit forms. * - * Additional annotation keys for widgets can be defined in + * Additional attribute keys for widgets can be defined in * hook_field_widget_info_alter(). * * @see \Drupal\Core\Field\WidgetPluginManager diff --git a/core/modules/field/field.api.php b/core/modules/field/field.api.php index ddaf9309e6..7656b41d58 100644 --- a/core/modules/field/field.api.php +++ b/core/modules/field/field.api.php @@ -173,7 +173,7 @@ function hook_field_storage_config_update_forbid(\Drupal\field\FieldStorageConfi * * @param array $info * An array of information on existing widget types, as collected by the - * annotation discovery mechanism. + * plugin discovery mechanism. */ function hook_field_widget_info_alter(array &$info) { // Let a new field type re-use an existing widget.
Fixed the above on commit. Also did this on the formatter issue too. I agree with @mstrelan that wording of additional keys is odd but saying annotation is worse than attribute so /shrug.
-
alexpott β
committed 890e58d7 on 10.3.x
Issue #3420978 by mstrelan, smustgrave: Convert FieldWidget plugin...
-
alexpott β
committed 890e58d7 on 10.3.x
- Status changed to Fixed
about 1 year ago 11:19am 2 March 2024 -
alexpott β
committed d0e96114 on 11.x
Issue #3420978 by mstrelan, smustgrave: Convert FieldWidget plugin...
-
alexpott β
committed d0e96114 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.