- Issue created by @quietone
- Status changed to Postponed
7 months ago 2:14am 13 February 2024 - ๐ณ๐ฟNew Zealand quietone New Zealand
Adding credit for the original MR that I merely copied here. Also postponing on #3419616: Create PHP 8.3 image containing sqlite 3.45 โ .
- Status changed to Needs review
7 months ago 10:02pm 13 February 2024 - Status changed to RTBC
7 months ago 11:12pm 13 February 2024 - Status changed to Needs review
7 months ago 11:00am 14 February 2024 - ๐ฌ๐งUnited Kingdom catch
Moving back to needs review until the image name is resolved - unless it can be changed on the image side with bc so that it doesn't break the new job.
- Status changed to Needs work
7 months ago 2:19pm 14 February 2024 - ๐ซ๐ทFrance andypost
Renaming an image makes the old image working so we can rename it later again without issue
Should we rename image if Ubuntu will package 3.46 at the time of release, so we end up with tons of image at dockerhub #3421477: Include DB type and major and minor version in TARGET_DB name โ
- ๐ณ๐ฟNew Zealand quietone New Zealand
I certainly don't want tons of images. Maybe we just need to keep comments up to date?
- Status changed to Needs review
5 months ago 5:24am 9 April 2024 - ๐ซ๐ทFrance andypost
I bet it needs to update the image with fresh version https://packages.ubuntu.com/noble/sqlite3 fixed CVE-2024-3094
meantime 3.45.2
UPSERT
regression fix from 3.35.0Meantime 3.45.1 in Debian trixie https://packages.debian.org/trixie/sqlite3
- ๐ณ๐ฟNew Zealand quietone New Zealand
What are the leftover sqlite runs that need to be changed?
- ๐ณ๐ฑNetherlands daffie
Could we set the minimum required version for SQLite in core/modules/sqlite/src/Driver/Database/sqlite/Install/Tasks.php to 3.45 for D11 and see that it passes the testbot.
- Status changed to Needs work
5 months ago 9:25pm 13 April 2024 - Status changed to Needs review
5 months ago 12:46pm 14 April 2024 - ๐บ๐ธUnited States smustgrave
smustgrave โ changed the visibility of the branch 11.x to hidden.
- ๐บ๐ธUnited States smustgrave
#16
Could we set the minimum required version for SQLite in core/modules/sqlite/src/Driver/Database/sqlite/Install/Tasks.php to 3.45 for D11 and see that it passes the testbot.
Adding this seems to break the tests. haven't reverted but is that showing a problem?
- ๐ฌ๐งUnited Kingdom catch
We have one build test that installs Drupal with --sqlite, we either need to make that test run only on the sqlite environment, or update sqlite on all the PHP 8.3 environments including MySQL and PostgresQL.
- ๐บ๐ธUnited States smustgrave
The sqllite test run passed but the default one is the failure.
- ๐ฌ๐งUnited Kingdom catch
Yes that's what I mean - the MySQL environment runs build tests, the build tests include a test that installs Drupal with sqlite, that test fails because (I assume) the sqlite version on the MySQL environment must be lower than 3.45.
- ๐ณ๐ฟNew Zealand quietone New Zealand
I changed InstallโTest.phpโ to check the SQLlite version before running as is done in other tests. That seems a reasonable approach to me.
- Status changed to RTBC
5 months ago 8:16am 15 April 2024 - ๐ฌ๐งUnited Kingdom catch
Yes #24 is great. Let's get this in, sorting out the image names can happen in a follow-up after they're standardized on the gitlab side.
- Status changed to Fixed
5 months ago 10:24am 15 April 2024 -
alexpott โ
committed 10466dba on 11.x
Issue #3420972 by quietone, andypost, smustgrave, catch, daffie: Add...
-
alexpott โ
committed 10466dba on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.