Add testing wtih SQLite 3.45

quietone → credited andypost → .

Adding credit for the original MR that I merely copied here. Also postponing on #3419616: Create PHP 8.3 image containing sqlite 3.45 → .

Renamed image and updated MR to see if tests are passing

Pushed 8.3-ubuntu image and MR is ready for review

Tests all green for 3.45

Moving back to needs review until the image name is resolved - unless it can be changed on the image side with bc so that it doesn't break the new job.

I gonna change image name as suggested today

Renaming an image makes the old image working so we can rename it later again without issue

Should we rename image if Ubuntu will package 3.46 at the time of release, so we end up with tons of image at dockerhub #3421477: Include DB type and major and minor version in TARGET_DB name →

I certainly don't want tons of images. Maybe we just need to keep comments up to date?

I bet it needs to update the image with fresh version https://packages.ubuntu.com/noble/sqlite3 fixed CVE-2024-3094

meantime 3.45.2 UPSERT regression fix from 3.35.0

Meantime 3.45.1 in Debian trixie https://packages.debian.org/trixie/sqlite3

What are the leftover sqlite runs that need to be changed?

Could we set the minimum required version for SQLite in core/modules/sqlite/src/Driver/Database/sqlite/Install/Tasks.php to 3.45 for D11 and see that it passes the testbot.

To try #16

Tests on SQLite 3.45 were run 5 days ago. see pipeline,

smustgrave → changed the visibility of the branch 11.x to hidden.

#16

Could we set the minimum required version for SQLite in core/modules/sqlite/src/Driver/Database/sqlite/Install/Tasks.php to 3.45 for D11 and see that it passes the testbot.

Adding this seems to break the tests. haven't reverted but is that showing a problem?

We have one build test that installs Drupal with --sqlite, we either need to make that test run only on the sqlite environment, or update sqlite on all the PHP 8.3 environments including MySQL and PostgresQL.

The sqllite test run passed but the default one is the failure.

Yes that's what I mean - the MySQL environment runs build tests, the build tests include a test that installs Drupal with sqlite, that test fails because (I assume) the sqlite version on the MySQL environment must be lower than 3.45.

I changed Install‎Test.php‎ to check the SQLlite version before running as is done in other tests. That seems a reasonable approach to me.

Yes #24 is great. Let's get this in, sorting out the image names can happen in a follow-up after they're standardized on the gitlab side.

Committed 10466db and pushed to 11.x. Thanks!

quietone → closed merge request !6564

Automatically closed - issue fixed for 2 weeks with no activity.