Search links always open new window / tab

Open on Drupal.org →

Created on 12 February 2024, 9 months ago

Updated 16 August 2024, 3 months ago

Problem/Motivation

When using the admin toolbar search, clicking the links opens the URL in the current tab, and in a new tab.

Seems likely to follow on from ✨ Make search links openable in new tabs Fixed

Steps to reproduce

1. enable admin_toolbar_search
2. type some text in the search box
3. click on the result

Expected result

The link should open in the same window and tab, unless you have chosen to open it in a new window

Actual result

The link opens in the current tab, and in a new tab.

If you use the keyboard arrows and enter key to visit the link, it does not open the extra tab.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Fixed

Version

3.4

Component

Code

Created by

🇬🇧United Kingdom malcomio

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!71Search links always open new window / tab
Merged
🇬🇧United Kingdom malcomio
updated 3 months ago

Comments & Activities

Issue created by @malcomio
Merge request !71Issue #3420788: Search links always open new window / tab → (Merged) created by malcomio
Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 9 months ago
Waiting for branch to pass
Status changed to Needs review 9 months ago10:40am 12 February 2024
Comment 9 months ago →
🇬🇧United Kingdom malcomio
Status changed to Needs work 9 months ago11:37am 12 February 2024
Comment 9 months ago →
🇮🇳India divya.sejekan
@malcomio Tested using MR 3.x and also 3420788-search-links-always . The issue is not fixed, still I can see the search links are opening in both the current and new tab
First commit to issue fork.
Status changed to RTBC 9 months ago11:27am 14 February 2024
Comment 9 months ago →
🇩🇪Germany marcoliver Neuss, NRW, Germany
Synced 3.x and 3420788-search-links-always in the issue fork.

Tested the behavior and it looks fine (video attached).

Marking RTBC.
Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update 9 months ago
Waiting for branch to pass
Comment 9 months ago →
🇨🇦Canada al_trottier
Adding a patch with the proposed MR from #2
Comment 5 months ago →
🇦🇺Australia jannakha Brisbane!
patch in #7 works,
please release new version
First commit to issue fork.
Pipeline finished with Skipped
3 months ago
#242247
Comment 3 months ago →
System Message

japerry → committed 68185d7f on 3.x authored by malcomio →
Issue #3420788: Search links always open new window / tab
Status changed to Fixed 3 months ago10:08pm 2 August 2024
Comment 3 months ago →
🇺🇸United States japerry KVUO
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024