- Issue created by @hamid.ali
- Assigned to sourabhsisodia_
- Issue was unassigned.
- Assigned to sourabhsisodia_
- Merge request !4property_zymphonies_theme-3419943: Updated the twitter logo to X → (Open) created by sourabhsisodia_
- Issue was unassigned.
- Status changed to Needs review
10 months ago 7:59am 8 February 2024 - Status changed to Needs work
10 months ago 9:38am 8 February 2024 - 🇮🇳India hamid.ali
@sourabhsisodia Instead of directly adding the twitter icon kindly use updated font awesome library to do the same in order to main the consistency throughout the project.
@hamid.ali In the theme code I have tried upgrading from Font Awesome from 5 to 6 but other icons are breaking in the site . They are not using any cdn for font awesome and updating it from 5 to 6 is just breaking the site
- Status changed to Needs review
10 months ago 9:45am 9 February 2024 - 🇮🇳India hamid.ali
I am adding the patch and the after-patch screenshot below for this issue.
Hi @Hamid.ali , I reviewed Twitter logo needs to be changed to the X
Before :
After applying the patch 3419943-10.patch →
The twitter icon updated to
- Status changed to RTBC
10 months ago 9:29am 16 February 2024 - 🇮🇳India Kanchan Bhogade
Hi,
Tested 3419943-10.patch on Drupal 10.1Test Result
The Twitter logo is updated with the patchAttaching screenshots
RTBC++