Help text is cutoff at xsmall breakpoint

Created on 7 February 2024, 5 months ago
Updated 11 April 2024, 3 months ago

Problem/Motivation

Experiencing an issue where the page help text can is cutoff at screens widths below the small breakpoint, and only on pages that do not have local tasks. We have various pages in farmOS where we add help text via hook_help() and started to notice that this text was being cutoff/removed on mobile in (it was working OK in firefox). The easiest way to reproduce in core may be the access denied page.

I believe this change was introduced with this commit: https://git.drupalcode.org/project/gin/-/commit/61e9cf2ec4e98c375850c6f0...

Steps to reproduce

Navigate to a page that renders the access denied page. Change width to less than 768 pixels and observe that text is cutoff.

Steps
1. Install the Gin theme and set it as the default
2. Create new user 'test user' with role content editor
3. Login with 'test user'
4. Go to page =>/admin/appearance/settings/gin
5. Check for the "Access denied" below 768px resolution

Proposed resolution

Investigate

Remaining tasks

Implement, test

User interface changes

Help text is always displayed, consistent spacing near top of page.

API changes

None

Data model changes

None

🐛 Bug report
Status

Fixed

Component

User interface

Created by

🇺🇸United States paul121 Spokane, WA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @paul121
  • 🇺🇸United States paul121 Spokane, WA

    Attaching screenshot examples

  • Merge request !385Only remove header whitespace at small screens → (Merged) created by paul121
  • Pipeline finished with Success
    5 months ago
    Total: 251s
    #90003
  • 🇺🇸United States paul121 Spokane, WA

    Here is a simple fix. Attaching a patch we can use in farmOS.

    Although I feel like there must be a more elegant solution because we are adding various margin-top, only to remove some of it from higher up in the .content-header. But it's tricky because the top margin is added to .help, .region-content and .region-highlighted. https://git.drupalcode.org/project/gin/-/blob/8.x-3.x/styles/base/_layer...

    To to properly test a more thorough change I think we would need to consider all combinations of pages with/without local tasks, help text, and status messages, all across different screen sizes.

  • Status changed to Needs review 5 months ago
  • 🇺🇸United States paul121 Spokane, WA
  • 🇮🇳India Kanchan Bhogade

    Hi,
    I have verified and tested MR ! 385 on Drupal version 10.1
    MR applied successfully...

    Testing Steps:

    1. Install the Drupal version and
    2. Install the Gin theme and set it as the default
    3. check for the "Access denied" below 768px resolution (before screenshot)
    4. Apply patch and check for the same

    Test Result:
    Access denied help text is responsive for below 768px resolution

    Attaching screenshots for reference.

    Status remains "need review" for code review

  • 🇮🇳India djsagar

    verified and tested MR !385, after applied MR issue resolved.

    Steps to reproduce
    1. Install the Gin theme and set it as the default
    2. Create new user 'test user' with role content editor
    3. Login with 'test user' (no need to provide )
    4. Go to page which link =>/admin/appearance/settings/gin
    5. Check for the "Access denied" below 768px resolution (before screenshot)
    6. Apply patch and check for the same

    For reference:
    Before MR

    After MR

    RTBC ++

  • Status changed to RTBC 5 months ago
  • Status changed to Fixed 3 months ago
  • 🇨🇭Switzerland saschaeggi Zurich

    Thanks 👏

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024