- Issue created by @quietone
- Merge request !6468File mime type and other file related words in the dictionary β (Closed) created by quietone
- Status changed to Needs review
11 months ago 9:56am 10 February 2024 - Status changed to Needs work
11 months ago 3:29pm 12 February 2024 - πΊπΈUnited States smustgrave
IS mentions removing kristiaan also but see that's still there.
- Status changed to Needs review
10 months ago 9:08am 5 March 2024 - π¬π§United Kingdom longwave UK
Personally I think we should wrap the long lists of these in cspell:disable/enable tags, and then perhaps individually ignore the cases in tests. These aren't real words, more like machine names, and if we add to the lists in the future we shouldn't need to consider them as spelling mistakes then either.
- π¬π§United Kingdom longwave UK
Tried that approach in MR!6918, only "msword" remains as it's used in a few more places - maybe we add this one to the dictionary? Not sure.
- Status changed to Needs work
10 months ago 12:22pm 5 March 2024 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π³πΏNew Zealand quietone
I didn't choose the option of enable/disable because there is an issue that adds a script to check 'cspell:ignore' lines for words that can be removed. Even with that I think this is better for readability, less clutter.
I add ignore lines for msword because it is only 4 file.
- Status changed to Needs review
10 months ago 6:18am 6 March 2024 - πΊπΈUnited States smustgrave
smustgrave β changed the visibility of the branch 3419394-file-mime-type to hidden.
- Status changed to RTBC
10 months ago 3:07pm 6 March 2024 - πΊπΈUnited States smustgrave
Made the assumption that MR 6468 was replaced by 6918
MR 6918 matches the proposed changes for words fixed.
- Status changed to Needs work
10 months ago 5:16am 7 March 2024 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to RTBC
10 months ago 6:19am 7 March 2024 - π¬π§United Kingdom longwave UK
Committed and pushed f8a2ccac36 to 11.x and dfafcf727f to 10.3.x. Thanks!
-
longwave β
committed dfafcf72 on 10.3.x
Issue #3419394 by quietone, longwave, smustgrave: File mime type and...
-
longwave β
committed dfafcf72 on 10.3.x
- Status changed to Fixed
10 months ago 11:46am 8 March 2024 -
longwave β
committed f8a2ccac on 11.x
Issue #3419394 by quietone, longwave, smustgrave: File mime type and...
-
longwave β
committed f8a2ccac on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.