Use constructor property promotion on $serializer in Drupal\Core\Cache\DatabaseBackend

Keshav Patel → made their first commit to this issue’s fork.

I've created another merge request to avoid overwriting anyone's changes. @acbramley, could you take a look? Is it finally a "property promotion"?

MR 6472 looks is what required but will have commit collision with 🐛 DatabaseBackend doesn't handle string typed $max_rows with $serializer Active

I've noticed this issue as well. Since I'm relatively new, could you explain how such conflicts are handled within the Drupal issue workflow? Will the conflicts be resolved in the issue that is merged first, or is there another way?

As the second one is RTBC already, let's keep this issue for rebase/re-roll

Sounds great, thanks

Postponing on 🐛 DatabaseBackend doesn't handle string typed $max_rows with $serializer Active soon as that lands this just needs to be rebased and put back in review

acbramley → changed the visibility of the branch 3419356-use-constructor-property to hidden.

Blocker is in :)

Looks mergeable now.

Somewhat off-topic: PHPCS suggests that the code $this->maxRows = $max_rows === NULL ? static::DEFAULT_MAX_ROWS : $max_rows; could be simplified to $this->maxRows = $max_rows ?? static::DEFAULT_MAX_ROWS;. Is it worth creating an issue for this?

Looking good, thanks!

Re #14 - yes that can definitely be tidied up in another issue :)

Committed 5ce8ede and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.