[10.2] ckeditor5_post_update_code_block() throws an error for format using CKE5 but with CKE4 settings

This patch worked for me:

Ok, the above patch is for Drpal 10.1, for 10.2 this one should do:

Actually,

$settings['toolbar']['items']

can never be NULL 😅

Can you please export your config as it was in Drupal 10.0 and post it here? 🙏

I think the issue is editor.editor.basic_html, it might be a lost migration or something. In the frontend it shows that now editor is selected, but in the config it has ckeditor5.

I attached a screenshot of the UI under drupal 10.0

Many migrations around the world are probably already in this state, as linkit 6.0 allows to upgrade to 10.0 but no further until it get's updated to 6.1.

Thx for looking into this!
Andreas

Thanks for exporting those 3 filter.format.* config entities 👍

• ✅ full_html looks fine — it contains:
  

  …
  settings:
    toolbar:
      items:
  …
  

• ✅ webform_default looks fine — same as above
• ❌ basic_html looks wrong — it contains:
  

  …
  editor: ckeditor5
  settings:
    toolbar:
      rows:
  …

basic_html claims to be using CKEditor 5, but its configuration is still for CKEditor 4.

Unfortunately the config export you shared is only showing the symptom, not the root cause — I still need to figure out the steps to reproduce this.

Questions to narrow down the root cause:

1. It sounds like when you were on Drupal 10.0, you had already upgraded all text formats to CKEditor 5?
2. How did you perform the CKEditor 4 → 5 upgrade?
3. Do you have a config/DB back-up of when you were still on CKEditor 4?
4. The https://www.drupal.org/files/issues/2024-02-05/Screenshot%202024-02-05%2... → screenshot does not even show basic_html (nor webform_default actually). That is caused by 🐛 Disabled text formats can't be seen in the GUI Needs review .
5. Do you have any content actually using the basic_html text format? (run the query SELECT COUNT(*) FROM node__body WHERE body_format = 'basic_html' to find out)

Wim Leers → credited catch → .

By the way, the only hunch I have right now is that this has the same root cause as the one @catch surfaced at #3374544-10: TypeError: array_intersect(): Argument #1 ($array) must be of type array, string given in array_intersect() (line 203 of .../core/modules/ckeditor5/src/Plugin/CKEditor5PluginManager.php). → , which would've been prevented by #2628144: Ensure that ConfigImport is taking place against the same code base → .

in_array(): Argument #2 ($haystack) must be of type array, null given in in_array()
core/modules/ckeditor5/ckeditor5.module(635): in_array('codeBlock', NULL, true)

in_array(): Argument #2 ($haystack) must be of type array, null given in in_array()
core/modules/ckeditor5/ckeditor5.module(635): in_array('codeBlock', NULL, true)