Convert FileTransferTest into a Kernel test

Created on 4 February 2024, 10 months ago
Updated 20 February 2024, 9 months ago

Problem/Motivation

\Drupal\Tests\system\Functional\FileTransfer\FileTransferTest Makes no HTTP requests but is a functional test.

Steps to reproduce

Proposed resolution

Convert \Drupal\Tests\system\Functional\FileTransfer\FileTransferTest into a Kernel test.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Needs work

Version

11.0 🔥

Component
PHPUnit 

Last updated about 8 hours ago

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @spokje
  • Merge request !6443First stab → (Open) created by spokje
  • Pipeline finished with Success
    10 months ago
    Total: 575s
    #87477
  • Pipeline finished with Success
    10 months ago
    Total: 648s
    #87492
  • Status changed to Needs review 10 months ago
  • 🇳🇱Netherlands spokje

    Very weird test IMHO.

    Maybe needs full refactoring?
    For me, that would be for a follow-up issue.

  • Status changed to Needs work 10 months ago
  • 🇬🇧United Kingdom longwave UK

    Unsure if we should just do the full refactor here or not. In the meantime, one comment on a test method.

  • Pipeline finished with Failed
    10 months ago
    Total: 161s
    #87692
  • Issue was unassigned.
  • Status changed to Needs review 10 months ago
  • 🇳🇱Netherlands spokje

    I think refactoring the test only might not be enough, all the "magic" that happens around here https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co... makes me a bit cringy...

    Also stuff seems to be broken already: 🐛 [regression] FTPExtension class can no longer connect as of 9.5.x Needs work

    So at this point in time I'm unsure what to do.

    For now I addressed the thread in the MR created by @longwave, but as mentioned in the comment, that also increases my cringe-level.

  • Pipeline finished with Success
    10 months ago
    Total: 574s
    #87696
  • 🇺🇸United States smustgrave

    Coverage doesn't appear lost but this one I'd probably wait for a 2nd +1 RTBC before marking.

  • First commit to issue fork.
  • Pipeline finished with Failed
    10 months ago
    Total: 168s
    #89388
  • 🇮🇳India sumit-k

    Per https://www.drupal.org/project/drupal/releases/10.2.0
    Drupal core automated tests and test APIs are being converted to require strict typing in all cases. So far, Drupal core test traits, build tests, and functional JavaScript tests all require strict typing. Going forward, all Drupal core tests will require strict typing. It is recommended that contributed and custom projects use the Drupal standard for strict type declaration.

    Added strict type and fixed phpcs issues.

  • Pipeline finished with Failed
    10 months ago
    Total: 6203s
    #89394
  • Status changed to Needs work 10 months ago
  • 🇺🇸United States smustgrave

    Actually this is converting an existing test. Adding strict typing seems out of scope for this issue

  • Pipeline finished with Failed
    9 months ago
    Total: 522s
    #94597
  • Status changed to Needs review 9 months ago
  • 🇮🇳India sumit-k

    Thank smustgrave for providing clarification on the scope. I've removed the strict type declaration and made some adjustments to adhere to coding standards.

  • Pipeline finished with Success
    9 months ago
    Total: 605s
    #97219
  • Status changed to Needs work 9 months ago
  • 🇺🇸United States smustgrave

    We should go back to commit https://git.drupalcode.org/project/drupal/-/merge_requests/6443/diffs?co... rest appears to be out of scope of the issue.

Production build 0.71.5 2024