- Issue created by @spokje
- Status changed to Needs review
10 months ago 6:41pm 4 February 2024 - 🇳🇱Netherlands spokje
Very weird test IMHO.
Maybe needs full refactoring?
For me, that would be for a follow-up issue. - Status changed to Needs work
10 months ago 7:56pm 4 February 2024 - 🇬🇧United Kingdom longwave UK
Unsure if we should just do the full refactor here or not. In the meantime, one comment on a test method.
- Issue was unassigned.
- Status changed to Needs review
10 months ago 7:23am 5 February 2024 - 🇳🇱Netherlands spokje
I think refactoring the test only might not be enough, all the "magic" that happens around here https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co... makes me a bit cringy...
Also stuff seems to be broken already: 🐛 [regression] FTPExtension class can no longer connect as of 9.5.x Needs work
So at this point in time I'm unsure what to do.
For now I addressed the thread in the MR created by @longwave, but as mentioned in the comment, that also increases my cringe-level.
- 🇺🇸United States smustgrave
Coverage doesn't appear lost but this one I'd probably wait for a 2nd +1 RTBC before marking.
- First commit to issue fork.
- 🇮🇳India sumit-k
Per https://www.drupal.org/project/drupal/releases/10.2.0 →
Drupal core automated tests and test APIs are being converted to require strict typing in all cases. So far, Drupal core test traits, build tests, and functional JavaScript tests all require strict typing. Going forward, all Drupal core tests will require strict typing. It is recommended that contributed and custom projects use the Drupal standard for strict type declaration.
Added strict type and fixed phpcs issues.
- Status changed to Needs work
10 months ago 1:03pm 7 February 2024 - 🇺🇸United States smustgrave
Actually this is converting an existing test. Adding strict typing seems out of scope for this issue
- Status changed to Needs review
9 months ago 7:16am 16 February 2024 - 🇮🇳India sumit-k
Thank smustgrave for providing clarification on the scope. I've removed the strict type declaration and made some adjustments to adhere to coding standards.
- Status changed to Needs work
9 months ago 3:18pm 20 February 2024 - 🇺🇸United States smustgrave
We should go back to commit https://git.drupalcode.org/project/drupal/-/merge_requests/6443/diffs?co... rest appears to be out of scope of the issue.