- Issue created by @Chi
- ๐ฎ๐ณIndia Keshav Patel
Keshav Patel โ made their first commit to this issueโs fork.
- Merge request !6442Issue #3419107: FieldConfigEditForm::save should report exceptions using warning or error messages โ (Open) created by Keshav Patel
- Status changed to Needs review
7 months ago 5:07pm 4 February 2024 - ๐ฎ๐ณIndia Keshav Patel
Changed it to be rendered as error message, instead of status message. Please review.
- Status changed to RTBC
7 months ago 6:18pm 4 February 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
This try catch is interesting - we don't normally do that for generic exceptions and this might not be necessary any more since we do a try catch for EntityStorageExceptions above... but there's notthing wrong in this change. Perhaps we could file a follow-up to remove this try catch and ensure that \Drupal\Tests\field_ui\Functional\ManageFieldsFunctionalTest::testExternalDestinations() still passes and explore the history of why this is there and catches such a generic exception.
Committed 36c3154 and pushed to 11.x. Thanks!
Committed 8097da0 and pushed to 10.3.x. Thanks!
Committed f0e32bb and pushed to 10.2.x. Thanks!Backported to 10.2.x as this is a non-disruptive bug fix.
-
alexpott โ
committed 65f0369b on 10.2.x
Issue #3419107 by Keshav Patel, Chi: FieldConfigEditForm::save should...
-
alexpott โ
committed 65f0369b on 10.2.x
-
alexpott โ
committed 8097da01 on 10.3.x
Issue #3419107 by Keshav Patel, Chi: FieldConfigEditForm::save should...
-
alexpott โ
committed 8097da01 on 10.3.x
- Status changed to Fixed
6 months ago 9:38am 29 February 2024 -
alexpott โ
committed 36c3154f on 11.x
Issue #3419107 by Keshav Patel, Chi: FieldConfigEditForm::save should...
-
alexpott โ
committed 36c3154f on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.