- Issue created by @quietone
- Status changed to Needs review
11 months ago 10:15am 4 February 2024 - Status changed to Needs work
11 months ago 6:29pm 5 February 2024 - Status changed to Needs review
11 months ago 10:44pm 5 February 2024 - Status changed to Needs work
11 months ago 11:09pm 5 February 2024 - π³πΏNew Zealand danielveza Brisbane, AU
Added a review, just had two tiny nit comments around formatting.
It might be out of scope for this issue, but I wonder if it's worth rewording some of the tests at some point so we don't need to add so many cspell ignores.
For example, "amphibius" isn't actually used for any form of testing. It's put in a comment body. We could just remove that from the comment then we wouldn't need the ignore.
- Status changed to Needs review
11 months ago 1:02am 6 February 2024 - π³πΏNew Zealand quietone
#9. Yes, that it a good point and I have changed many strings that use English nonsense words to something else in English. But it is also respectful and inclusive to our contributors to leave non English test strings.
- π³πΏNew Zealand danielveza Brisbane, AU
Just one small comment left unrsolved in the MR https://git.drupalcode.org/project/drupal/-/merge_requests/6440#note_261850.
Not changing the status in case that hasn't been done on purpose but I think it would be good for consistency :)
- π³πΏNew Zealand quietone
I missed removing a word, antilop', from the dictionary as well.
- Status changed to RTBC
11 months ago 9:13am 6 February 2024 - π³πΏNew Zealand danielveza Brisbane, AU
Looks good to me, feedback has been addressed. I'm happy to mark this RTBC
- Status changed to Fixed
11 months ago 10:34am 6 February 2024 -
longwave β
committed cc2223a9 on 11.x
Issue #3419070 by quietone, DanielVeza, smustgrave: Remove 14 foreign...
-
longwave β
committed cc2223a9 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.